On Mon, 2009-12-21 at 17:38 +0100, Bert Huijben wrote:
>
> > -Original Message-
> > From: Julian Foad [mailto:julianf...@btopenworld.com]
> > > Maybe assertions and aborts are easier for Subversion developers, but
> > they are not for our users.
> >
> > That's just stating what happens if
Stefan Sperling wrote:
> I'll stay out of the whole SVN_ERR_ASSERT discussion.
> If we boil down the diff as below is this OK?
> Index: subversion/libsvn_fs_fs/fs_fs.c
> ===
> --- subversion/libsvn_fs_fs/fs_fs.c (revision 892649)
>
27;; 'Philip Martin'; 'Mark Phippard';
> > dev@subversion.apache.org
> > Subject: RE: svn commit: r884250 -
> > /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
> >
> > Bert Huijben wrote:
> > >
> > > > -Original Message-
> &
> -Original Message-
> From: Julian Foad [mailto:julianf...@btopenworld.com]
> Sent: maandag 21 december 2009 16:51
> To: Bert Huijben
> Cc: 'Stefan Sperling'; 'Philip Martin'; 'Mark Phippard';
> dev@subversion.apache.org
> Sub
Bert Huijben wrote:
>
> > -Original Message-
> > From: Julian Foad [mailto:julian.f...@wandisco.com]
> > Sent: maandag 21 december 2009 16:05
> > To: Stefan Sperling
> > Cc: Philip Martin; Mark Phippard; dev@subversion.apache.org
> > Subject: Re
"Bert Huijben" writes:
>> -Original Message- From: Julian Foad
>> [mailto:julian.f...@wandisco.com] Sent: maandag 21 december 2009
>> 16:05 To: Stefan Sperling Cc: Philip Martin; Mark Phippard;
>> dev@subversion.apache.org Subject: Re: svn comm
> -Original Message-
> From: Julian Foad [mailto:julian.f...@wandisco.com]
> Sent: maandag 21 december 2009 16:05
> To: Stefan Sperling
> Cc: Philip Martin; Mark Phippard; dev@subversion.apache.org
> Subject: Re: svn commit: r884250 -
> /subversion/trunk/subversion
Stefan Sperling wrote:
> - assert(strlen(txn_id) < sizeof(txn->txn_id));
> - strncpy(txn->txn_id, txn_id, sizeof(txn->txn_id) - 1);
> - txn->txn_id[sizeof(txn->txn_id) - 1] = '\0';
> + end = apr_cpystrn(txn->txn_id, txn_id, sizeof(txn->txn_id));
> + if (end < txn->txn_id + strlen(txn_id))
> +
On Wed, Nov 25, 2009 at 09:15:03PM +, Philip Martin wrote:
> Stefan Sperling writes:
>
> > On Wed, Nov 25, 2009 at 03:51:43PM -0500, Mark Phippard wrote:
> >> On Wed, Nov 25, 2009 at 3:27 PM, wrote:
> >> > Author: stsp
> >> > Date: Wed Nov 25 20:27:38 2009
> >> > New Revision: 884250
> >> >
Stefan Sperling writes:
> On Wed, Nov 25, 2009 at 03:51:43PM -0500, Mark Phippard wrote:
>> On Wed, Nov 25, 2009 at 3:27 PM, wrote:
>> > Author: stsp
>> > Date: Wed Nov 25 20:27:38 2009
>> > New Revision: 884250
>> >
>> > URL: http://svn.apache.org/viewvc?rev=884250&view=rev
>> > Log:
>> > Repl
On Wed, Nov 25, 2009 at 03:51:43PM -0500, Mark Phippard wrote:
> On Wed, Nov 25, 2009 at 3:27 PM, wrote:
> > Author: stsp
> > Date: Wed Nov 25 20:27:38 2009
> > New Revision: 884250
> >
> > URL: http://svn.apache.org/viewvc?rev=884250&view=rev
> > Log:
> > Replace use of strcpy() in libsvn_fs_fs,
On Wed, Nov 25, 2009 at 3:27 PM, wrote:
> Author: stsp
> Date: Wed Nov 25 20:27:38 2009
> New Revision: 884250
>
> URL: http://svn.apache.org/viewvc?rev=884250&view=rev
> Log:
> Replace use of strcpy() in libsvn_fs_fs, my compiler keeps complaining.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (get_s
12 matches
Mail list logo
