Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-12 Thread Ivan Zhakov
On 12 March 2015 at 14:33, Branko Čibej wrote: > On 12.03.2015 09:27, Branko Čibej wrote: > > On 12.03.2015 08:49, Bert Huijben wrote: > > This resolves several signed compared to unsigned warnings on Windows. > > It is nice to fix warnings for some favorite compiler, but there are still > > 200 w

Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-12 Thread Branko Čibej
On 12.03.2015 09:27, Branko Čibej wrote: > On 12.03.2015 08:49, Bert Huijben wrote: >> This resolves several signed compared to unsigned warnings on Windows. >> >> It is nice to fix warnings for some favorite compiler, but there are >> still > 200 warnings left on Windows, especially on cases that

Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-12 Thread Branko Čibej
On 12.03.2015 09:51, Bert Huijben wrote: > > r1665853 is not in STATUS as far as I can tell. (I usually don’t > nominate warning fixes). > Sorry, I confused that with something else because I did find the warning during backport review; ignore that. -- Brane

RE: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-12 Thread Bert Huijben
to 'svn_revnum_t', possible loss of data 1>..\..\..\subversion\libsvn_fs_x\cached_data.c(1822): warning C4244: 'function' : conversion from 'svn_filesize_t' to 'apr_size_t', possible loss of data 1>..\..\..\subversion\libsvn_fs_x\cached_data.c(236

Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-12 Thread Branko Čibej
On 12.03.2015 08:49, Bert Huijben wrote: > This resolves several signed compared to unsigned warnings on Windows. > > It is nice to fix warnings for some favorite compiler, but there are > still > 200 warnings left on Windows, especially on cases that assume > int and size_t variants have identical

Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-12 Thread Bert Huijben
This resolves several signed compared to unsigned warnings on Windows. It is nice to fix warnings for some favorite compiler, but there are still > 200 warnings left on Windows, especially on cases that assume int and size_t variants have identical length, which doesn’t hold on Win64. Bert

Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2015-03-11 Thread Branko Čibej
On 11.03.2015 13:02, rhuij...@apache.org wrote: > Author: rhuijben > Date: Wed Mar 11 12:02:50 2015 > New Revision: 1665853 > > URL: http://svn.apache.org/r1665853 > Log: > * subversion/libsvn_diff/diff_file.c > (svn_diff3__file_output_baton_t): Use apr_size_t to avoid some warnings, > on usa