Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Branko Čibej
On 03.03.2015 19:10, Julian Foad wrote: > Stefan Fuhrmann wrote: >> Julian Foad wrote: >>> #define svn_hash_sets(ht, key, val) \ >>> do { \ >>> const char *svn_hash__key = (key); \

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Stefan Fuhrmann
On Tue, Mar 3, 2015 at 7:10 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: > > Julian Foad wrote: > >> #define svn_hash_sets(ht, key, val) \ > >> do { \ > >> const char *svn_hash__key = (key);

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Julian Foad
Stefan Fuhrmann wrote: > Julian Foad wrote: >> #define svn_hash_sets(ht, key, val)  \ >>   do {   \ >>     const char *svn_hash__key = (key);   \ >>     apr_hash_set(ht, svn_hash__key, APR_HA

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Stefan Fuhrmann
On Tue, Mar 3, 2015 at 5:19 PM, Julian Foad wrote: > [Switching back to plain text] > > Stefan Fuhrmann wrote: > > Julian Foad wrote: > >> Thinking about how to prevent a repeat of the same kind of error, > >> defining svn_hash_sets and svn_hash_gets as functions with prototypes > >> would result

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Julian Foad
[Switching back to plain text] Stefan Fuhrmann wrote: > Julian Foad wrote: >> Thinking about how to prevent a repeat of the same kind of error, >> defining svn_hash_sets and svn_hash_gets as functions with prototypes >> would result in at least a compiler warning (for typical configurations). > >

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Stefan Fuhrmann
On Tue, Mar 3, 2015 at 12:17 PM, Julian Foad wrote: > >>> URL: http://svn.apache.org/r1663450 > > >>> Log: > >>> Following up on r1658194, fix removing tokens from the tokens cache. > >>> Just passing the token to svn_hash_sets() didn't work any more. > My bad. Talked about the leak on IRC last

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Ivan Zhakov
On 3 March 2015 at 14:17, Julian Foad wrote: URL: http://svn.apache.org/r1663450 > Log: Following up on r1658194, fix removing tokens from the tokens cache. Just passing the token to svn_hash_sets() didn't work any more. > > Thinking about how to prevent a repeat of the same ki

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Julian Foad
>>> URL: http://svn.apache.org/r1663450 >>> Log: >>> Following up on r1658194, fix removing tokens from the tokens cache. >>> Just passing the token to svn_hash_sets() didn't work any more. Thinking about how to prevent a repeat of the same kind of error, defining svn_hash_sets and svn_hash_gets

RE: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: dinsdag 3 maart 2015 11:03 > To: dev@subversion.apache.org; Bert Huijben > Subject: Re: svn commit: r1663450 - > /subversion/trunk/subversion/libsvn_ra_svn/editorp.c > > On 3 Marc

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

2015-03-03 Thread Ivan Zhakov
On 3 March 2015 at 01:26, wrote: > Author: rhuijben > Date: Mon Mar 2 22:26:07 2015 > New Revision: 1663450 > > URL: http://svn.apache.org/r1663450 > Log: > Following up on r1658194, fix removing tokens from the tokens cache. > Just passing the token to svn_hash_sets() didn't work any more. > >