Re: svn commit: r1482282 - svn_nls_init on Windows

2013-05-14 Thread Julian Foad
Bert Huijben wrote: > Julian Foad wrote: >> (1) Inserting a UCS-2 string into a UTF-8 error message will surely fail >> in one way or another. >> >> (2) Just below this error handling, the code to write the null terminator >> is bogus. >> >> I suggest: [...] >> -  err = svn_error_cr

RE: svn commit: r1482282 - svn_nls_init on Windows

2013-05-14 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: dinsdag 14 mei 2013 18:05 > To: BertHuijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1482282 - svn_nls_init on Windows > > Bert Huijben wrote: > > URL:

Re: svn commit: r1482282 - svn_nls_init on Windows

2013-05-14 Thread Julian Foad
Bert Huijben wrote: > URL: http://svn.apache.org/r1482282 > Log: > * subversion/libsvn_subr/nls.c >   (svn_nls_init): Don't use an uninitialized variable to produce a very >     unlikely if not impossible to reach error. > > Modified: subversion/trunk/subversion/libsvn_subr/nls.c > ===