Re: svn commit: r1471717 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2013-04-25 Thread Daniel Shahaf
Ivan Zhakov wrote on Thu, Apr 25, 2013 at 13:29:05 +0400: > On Thu, Apr 25, 2013 at 3:14 AM, Daniel Shahaf > wrote: > > On IRC you also made a point about the "Config files" output (prints the > > path to DB_CONFIG or to fsfs.conf). Do you think it should be removed > > from 'svnadmin info'? Fr

Re: svn commit: r1471717 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2013-04-25 Thread Ivan Zhakov
On Thu, Apr 25, 2013 at 3:14 AM, Daniel Shahaf wrote: > Ivan Zhakov wrote on Thu, Apr 25, 2013 at 02:58:05 +0400: >> On Thu, Apr 25, 2013 at 2:01 AM, wrote: [...] > > *nod*. Is that your preference or the project-agreed style? > It's not project agreed style, but I remember some discussions on

Re: svn commit: r1471717 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2013-04-24 Thread Daniel Shahaf
Ivan Zhakov wrote on Thu, Apr 25, 2013 at 02:58:05 +0400: > On Thu, Apr 25, 2013 at 2:01 AM, wrote: > > +svn_error_t * > > +subcommand_info(apr_getopt_t *os, void *baton, apr_pool_t *pool) > > +{ > > + SVN_ERR(svn_cmdline_printf(pool, _("Path: %s\n"), > > + svn_repos_

Re: svn commit: r1471717 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2013-04-24 Thread Ivan Zhakov
On Thu, Apr 25, 2013 at 2:01 AM, wrote: > URL: http://svn.apache.org/r1471717 > Log: > Implement 'svnadmin info'. > See my review inline. > Modified: > subversion/trunk/subversion/svnadmin/svnadmin.c > > Modified: subversion/trunk/subversion/svnadmin/svnadmin.c > URL: > http://svn.apache.or