Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-12 Thread Johan Corveleyn
On Tue, Jun 12, 2012 at 8:22 AM, Justin Erenkrantz wrote: > On Tuesday, June 12, 2012, C. Michael Pilato wrote: >> On 06/10/2012 09:13 AM, Justin Erenkrantz wrote: >> > How does the user recover?  Less of an issue when we have WC-specific >> > pristines, but itis more of an issue as we move toward

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-11 Thread Justin Erenkrantz
On Tuesday, June 12, 2012, C. Michael Pilato wrote: > On 06/10/2012 09:13 AM, Justin Erenkrantz wrote: > > One question: what happens when the WC's pristine gets corrupted. That > is, > > we originally get the pristine properly, stash it in the local DB, but > > something happens later and that f

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-11 Thread C. Michael Pilato
On 06/10/2012 09:13 AM, Justin Erenkrantz wrote: > One question: what happens when the WC's pristine gets corrupted. That is, > we originally get the pristine properly, stash it in the local DB, but > something happens later and that file changes content due to corruption. > > Specifically: > >

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-11 Thread C. Michael Pilato
On 06/10/2012 09:28 AM, Justin Erenkrantz wrote: > On Friday, June 8, 2012, C. Michael Pilato wrote: > > On 06/08/2012 03:15 PM, Ivan Zhakov wrote: > > Wow, but performance will be much more interesting if we inline > > properties to REPORT response. Mike, could you please share your >

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-11 Thread Justin Erenkrantz
I am not against server-side changes - but, I want to have evidence backing up that Depth 1 (which should work on older servers) is significantly slower than modifying the report. If we do get all props with the REPORT response, we are going to have to do tricks on the client side as we can't proc

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-11 Thread Ivan Zhakov
On Sun, Jun 10, 2012 at 9:19 AM, Justin Erenkrantz wrote: > On Friday, June 8, 2012, C. Michael Pilato wrote: >> >> On 06/08/2012 03:15 PM, Ivan Zhakov wrote: >> > Wow, but performance will be much more interesting if we inline >> > properties to REPORT response. Mike, could you please share your

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-10 Thread Greg Stein
On Jun 10, 2012 3:29 AM, "Justin Erenkrantz" wrote: > > On Friday, June 8, 2012, C. Michael Pilato wrote: >>... >> Sure. Attached. > > > From a quick review of the patch, I am not seeing how we are delaying the client's editor drive to set the property until we have received the file contents. A

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-10 Thread Greg Stein
On Jun 10, 2012 3:20 AM, "Justin Erenkrantz" wrote: > > On Friday, June 8, 2012, C. Michael Pilato wrote: >> >> On 06/08/2012 03:15 PM, Ivan Zhakov wrote: >> > Wow, but performance will be much more interesting if we inline >> > properties to REPORT response. Mike, could you please share your >> >

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-10 Thread Justin Erenkrantz
On Friday, June 8, 2012, C. Michael Pilato wrote: > On 06/08/2012 03:15 PM, Ivan Zhakov wrote: > > Wow, but performance will be much more interesting if we inline > > properties to REPORT response. Mike, could you please share your > > incomplete patch for including properties to REPORT response?

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-10 Thread Justin Erenkrantz
On Friday, June 8, 2012, C. Michael Pilato wrote: > On 06/08/2012 03:15 PM, Ivan Zhakov wrote: > > Wow, but performance will be much more interesting if we inline > > properties to REPORT response. Mike, could you please share your > > incomplete patch for including properties to REPORT response?

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-10 Thread Justin Erenkrantz
On Friday, June 8, 2012, Branko Čibej wrote: > > That's ... amazing. I wonder where we'll pay for it. > One question: what happens when the WC's pristine gets corrupted. That is, we originally get the pristine properly, stash it in the local DB, but something happens later and that file changes c

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-08 Thread C. Michael Pilato
On 06/08/2012 03:15 PM, Ivan Zhakov wrote: > Wow, but performance will be much more interesting if we inline > properties to REPORT response. Mike, could you please share your > incomplete patch for including properties to REPORT response? Sure. Attached. -- C. Michael Pilato CollabNet <>

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-08 Thread Ivan Zhakov
On Fri, Jun 8, 2012 at 9:41 PM, Mark Phippard wrote: > On Fri, Jun 8, 2012 at 12:01 PM,   wrote: >> Author: cmpilato >> Date: Fri Jun  8 16:01:00 2012 >> New Revision: 1348131 >> >> URL: http://svn.apache.org/viewvc?rev=1348131&view=rev >> Log: >> Finish issue #4179 by eliminating no-op HEAD reque

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-08 Thread Branko Čibej
On 08.06.2012 20:58, Philip Martin wrote: > "C. Michael Pilato" writes: > >> On 06/08/2012 01:41 PM, Mark Phippard wrote: >>> On Fri, Jun 8, 2012 at 12:01 PM, wrote: Author: cmpilato Date: Fri Jun 8 16:01:00 2012 New Revision: 1348131 URL: http://svn.apache.org/viewvc?r

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-08 Thread Philip Martin
"C. Michael Pilato" writes: > On 06/08/2012 01:41 PM, Mark Phippard wrote: >> On Fri, Jun 8, 2012 at 12:01 PM, wrote: >>> Author: cmpilato >>> Date: Fri Jun 8 16:01:00 2012 >>> New Revision: 1348131 >>> >>> URL: http://svn.apache.org/viewvc?rev=1348131&view=rev >>> Log: >>> Finish issue #4179

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-08 Thread C. Michael Pilato
On 06/08/2012 01:41 PM, Mark Phippard wrote: > On Fri, Jun 8, 2012 at 12:01 PM, wrote: >> Author: cmpilato >> Date: Fri Jun 8 16:01:00 2012 >> New Revision: 1348131 >> >> URL: http://svn.apache.org/viewvc?rev=1348131&view=rev >> Log: >> Finish issue #4179 by eliminating no-op HEAD requests from

Re: svn commit: r1348131 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-06-08 Thread Mark Phippard
On Fri, Jun 8, 2012 at 12:01 PM, wrote: > Author: cmpilato > Date: Fri Jun  8 16:01:00 2012 > New Revision: 1348131 > > URL: http://svn.apache.org/viewvc?rev=1348131&view=rev > Log: > Finish issue #4179 by eliminating no-op HEAD requests from ra_serf's > checkout/update logic. Nice! This makes