Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-03-06 Thread Stefan Sperling
On Tue, Mar 06, 2012 at 12:39:27PM +, Julian Foad wrote: > Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Mon, Feb 06, 2012 at 18:20:28 +0200: > >> Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100: > >> > On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote: > >> > >

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-03-06 Thread Julian Foad
Daniel Shahaf wrote: > Daniel Shahaf wrote on Mon, Feb 06, 2012 at 18:20:28 +0200: >> Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100: >> > On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote: >> > > This still strips whitespace around ='s in the value: >> > >    SVNHoo

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-03-04 Thread Daniel Shahaf
Daniel Shahaf wrote on Mon, Feb 06, 2012 at 18:20:28 +0200: > Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100: > > On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote: > > > This still strips whitespace around ='s in the value: > > > SVNHooksEnv "name = x = y" > > > will

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-02-06 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100: > On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote: > > This still strips whitespace around ='s in the value: > > SVNHooksEnv "name = x = y" > > will result in > > setenv("name", "x=y", 1) > > whereas I believe it sh

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-02-06 Thread Stefan Sperling
On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote: > This still strips whitespace around ='s in the value: > SVNHooksEnv "name = x = y" > will result in > setenv("name", "x=y", 1) > whereas I believe it should result in > setenv("name", "x = y", 1) > (and, to be honest, I'd

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-02-06 Thread Daniel Shahaf
This still strips whitespace around ='s in the value: SVNHooksEnv "name = x = y" will result in setenv("name", "x=y", 1) whereas I believe it should result in setenv("name", "x = y", 1) (and, to be honest, I'd be happy with setenv("name ", " x = y", 1) as well). WDYT? How should i