Re: svn commit: r1181090 - Follow-up to r1180154: svn_rangelist_merge2 optimization.

2011-10-21 Thread Julian Foad
Paul Burba wrote: > No, we can trim that first block.  I did that along with some > additional simplifications in r1187042. Thanks, Paul. Looks nice now. Sorry, Bert, for causing confusing in the email thread by not quoting enough context. - Julian

Re: svn commit: r1181090 - Follow-up to r1180154: svn_rangelist_merge2 optimization.

2011-10-20 Thread Paul Burba
ubject: RE: svn commit: r1181090 - Follow-up to r1180154: >> svn_rangelist_merge2 optimization. >> >> > -Original Message- >> > From: Julian Foad [mailto:julian.f...@wandisco.com] >> > Sent: donderdag 20 oktober 2011 16:45 >> >

RE: svn commit: r1181090 - Follow-up to r1180154: svn_rangelist_merge2 optimization.

2011-10-20 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: donderdag 20 oktober 2011 16:48 > To: 'Julian Foad'; 'Paul Burba'; dev@subversion.apache.org > Subject: RE: svn commit: r1181090 - Follow-up to r1180154:

RE: svn commit: r1181090 - Follow-up to r1180154: svn_rangelist_merge2 optimization.

2011-10-20 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: donderdag 20 oktober 2011 16:45 > To: Paul Burba; dev@subversion.apache.org > Subject: Re: svn commit: r1181090 - Follow-up to r1180154: > svn_rangelist_merge2 optimization. > >

Re: svn commit: r1181090 - Follow-up to r1180154: svn_rangelist_merge2 optimization.

2011-10-20 Thread Julian Foad
Hi Paul. It looks like we can simplify this by omitting the first branch of the if ... else ... else construct: [[[ if (delete_index == (arr->nelts - 1)) { /* Deleting the last or only element in an array is easy. */ apr_array_pop(arr); } + else