Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-20 Thread Julian Foad
Daniel Shahaf wrote: > One alternative solution is having svn_fs_fs__verify() stat() the DB > file for existence before attempting to operate on it. > > I don't think it's the most elegant thing in the world, but it avoids > spuriously creating the DB file without complicating the common case > lo

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-19 Thread Daniel Shahaf
One alternative solution is having svn_fs_fs__verify() stat() the DB file for existence before attempting to operate on it. I don't think it's the most elegant thing in the world, but it avoids spuriously creating the DB file without complicating the common case logic. I'm also open to alternati

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-19 Thread Julian Foad
On Thu, 2011-07-14, Daniel Shahaf wrote: > I've looked again at the code. Right now it opens the db, with > svn_sqlite__mode_rwcreate, within an svn_atomic_init_once() block. > > Adding the special case "For caller use svn_sqlite__mode_readwrite" > means we can't use svn_atomic_init_once() any m

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-14 Thread Daniel Shahaf
I've looked again at the code. Right now it opens the db, with svn_sqlite__mode_rwcreate, within an svn_atomic_init_once() block. Adding the special case "For caller use svn_sqlite__mode_readwrite" means we can't use svn_atomic_init_once() any more. (since it's no longer "once", maybe the first

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-14 Thread Julian Foad
On Thu, 2011-07-14 at 04:10 +0300, Daniel Shahaf wrote: > Greg Stein wrote on Wed, Jul 13, 2011 at 20:54:56 -0400: > > On Wed, Jul 13, 2011 at 20:32, wrote: > > > Author: danielsh > > > Date: Thu Jul 14 00:32:05 2011 > > > New Revision: 1146528 > > > > > > URL: http://svn.apache.org/viewvc?rev=11

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-13 Thread Greg Stein
On Wed, Jul 13, 2011 at 21:10, Daniel Shahaf wrote: > Greg Stein wrote on Wed, Jul 13, 2011 at 20:54:56 -0400: >> On Wed, Jul 13, 2011 at 20:32,   wrote: >> > Author: danielsh >> > Date: Thu Jul 14 00:32:05 2011 >> > New Revision: 1146528 >> > >> > URL: http://svn.apache.org/viewvc?rev=1146528&vie

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-13 Thread Daniel Shahaf
Greg Stein wrote on Wed, Jul 13, 2011 at 20:54:56 -0400: > On Wed, Jul 13, 2011 at 20:32, wrote: > > Author: danielsh > > Date: Thu Jul 14 00:32:05 2011 > > New Revision: 1146528 > > > > URL: http://svn.apache.org/viewvc?rev=1146528&view=rev > > Log: > > * subversion/libsvn_fs_fs/fs_fs.c > >  (wr

Re: svn commit: r1146528 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2011-07-13 Thread Greg Stein
On Wed, Jul 13, 2011 at 20:32, wrote: > Author: danielsh > Date: Thu Jul 14 00:32:05 2011 > New Revision: 1146528 > > URL: http://svn.apache.org/viewvc?rev=1146528&view=rev > Log: > * subversion/libsvn_fs_fs/fs_fs.c >  (write_config): Document that 'svnadmin verify' will access (and thus create)