Re: svn commit: r1139573 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2011-06-27 Thread Julian Foad
Justin Erenkrantz wrote: > On Sat, Jun 25, 2011 at 12:50 PM, Ivan Zhakov wrote: > >> Why apr_fnmatch() here? These aren't filenames. Shouldn't this just be > >> a case-insensitive string compare? > >> > > I think because of wildcard certificates, e.g *.example.com. > > Yup - what he said. -- ju

Re: svn commit: r1139573 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2011-06-26 Thread Justin Erenkrantz
On Sat, Jun 25, 2011 at 12:50 PM, Ivan Zhakov wrote: >> Why apr_fnmatch() here? These aren't filenames. Shouldn't this just be >> a case-insensitive string compare? >> > I think because of wildcard certificates, e.g  *.example.com. Yup - what he said. -- justin

Re: svn commit: r1139573 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2011-06-25 Thread Ivan Zhakov
On Sat, Jun 25, 2011 at 23:14, Greg Stein wrote: > On Sat, Jun 25, 2011 at 13:23,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Sat Jun 25 17:23:28 >> 2011 >>... >> @@ -227,8 +230,22 @@ ssl_server_cert(void *baton, int failure >> >>   svn_failures = ssl_convert_serf_fail

Re: svn commit: r1139573 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2011-06-25 Thread Greg Stein
On Sat, Jun 25, 2011 at 13:23, wrote: >... > +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Sat Jun 25 17:23:28 2011 >... > @@ -227,8 +230,22 @@ ssl_server_cert(void *baton, int failure > >   svn_failures = ssl_convert_serf_failures(failures); > > +  /* Try to find matching server name via