Re: sqlite3.c won't compile with -std=c89

2013-05-07 Thread Branko Čibej
On 01.05.2013 01:47, Mattias Engdegård wrote: > 25 mar 2013 kl. 23.03 skrev Mattias Engdegård: > >> [[[ >> Work around a problem on older OS X systems: sqlite3.c includes >> , which uses 'inline' and thus cannot be compiled >> with -std=c89 that we are using for all files. >> >> * subversion/libsvn

Re: sqlite3.c won't compile with -std=c89

2013-04-30 Thread Mattias Engdegård
25 mar 2013 kl. 23.03 skrev Mattias Engdegård: [[[ Work around a problem on older OS X systems: sqlite3.c includes , which uses 'inline' and thus cannot be compiled with -std=c89 that we are using for all files. * subversion/libsvn_subr/sqlite3wrapper.c (toplevel): Define 'inline' as '__inline

Re: sqlite3.c won't compile with -std=c89

2013-03-25 Thread Mattias Engdegård
25 mar 2013 kl. 05.42 skrev Branko Čibej: I'm not too happy with this patch because the hack is not restricted to only those versions of OS X that actually need it. It's not needed, to my knowledge, at least since 10.6; the latest version ofthat header uses __inline rather than inline,

Re: sqlite3.c won't compile with -std=c89

2013-03-24 Thread Branko Čibej
On 24.03.2013 20:59, Mattias Engdegård wrote: > Unfortunately I missed a second compilation of sqlite3.c, in > wc-queries-test.c. Here's an updated patch. Sorry about not getting it > right the first time. > > [[[ > Work around a problem on older OS X systems: sqlite3.c includes > , which uses 'inl

Re: sqlite3.c won't compile with -std=c89

2013-03-24 Thread Branko Čibej
On 24.03.2013 20:46, Ivan Zhakov wrote: > On Sun, Mar 24, 2013 at 5:36 PM, Mattias Engdegård > wrote: >> The attached patch is an alternative way of solving this particular problem. >> >> [[[ >> Work around a problem on older OS X systems: sqlite3.c includes >> , which uses 'inline' and thus canno

Re: sqlite3.c won't compile with -std=c89

2013-03-24 Thread Mattias Engdegård
Unfortunately I missed a second compilation of sqlite3.c, in wc- queries-test.c. Here's an updated patch. Sorry about not getting it right the first time. [[[ Work around a problem on older OS X systems: sqlite3.c includes , which uses 'inline' and thus cannot be compiled with -std=c89 that we

Re: sqlite3.c won't compile with -std=c89

2013-03-24 Thread Ivan Zhakov
On Sun, Mar 24, 2013 at 5:36 PM, Mattias Engdegård wrote: > The attached patch is an alternative way of solving this particular problem. > > [[[ > Work around a problem on older OS X systems: sqlite3.c includes > , which uses 'inline' and thus cannot be compiled > with -std=c89 that we are using f

Re: sqlite3.c won't compile with -std=c89

2013-03-24 Thread Mattias Engdegård
The attached patch is an alternative way of solving this particular problem. [[[ Work around a problem on older OS X systems: sqlite3.c includes , which uses 'inline' and thus cannot be compiled with -std=c89 that we are using for all files. * subversion/libsvn_subr/sqlite3wrapper.c (topleve

Re: sqlite3.c won't compile with -std=c89

2013-03-24 Thread Mattias Engdegård
24 mar 2013 kl. 02.39 skrev Ben Reser: I build trunk on OS X at least once a day with sqlite-amalgamation and it builds fine for me. It throws a bunch of warnings but I don't think the warnings have anything to do with -std=c89. What errors or problems are you seeing? What compiler are you us

Re: sqlite3.c won't compile with -std=c89

2013-03-23 Thread Ben Reser
On Sat, Mar 23, 2013 at 4:00 PM, Mattias Engdegård wrote: > sqlite3.c (from the amalgamation) cannot in general be compiled with > -std=c89, which the Subversion build universally uses in trunk. How do we > make an exception for a single file, to have it compiled with a different > set of flags? >