Re: pristine store database -- was: pristine store design

2010-02-17 Thread Hyrum K. Wright
On Feb 16, 2010, at 10:52 PM, Neels J Hofmeyr wrote: > Greg Stein wrote: >> On Tue, Feb 16, 2010 at 16:22, Johan Corveleyn wrote: >>> OTOH, I guess a 0 bytes pristine has to be handled specially anyway >>> (what's the checksum of 0 bytes), no? > > SHA1: da39a3ee5e6b4b0d3255bfef95601890afd80709

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Neels J Hofmeyr
Greg Stein wrote: > On Tue, Feb 16, 2010 at 16:22, Johan Corveleyn wrote: >> OTOH, I guess a 0 bytes pristine has to be handled specially anyway >> (what's the checksum of 0 bytes), no? SHA1: da39a3ee5e6b4b0d3255bfef95601890afd80709 MD5: d41d8cd98f00b204e9800998ecf8427e ;) > > Oops. You're rig

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Greg Stein
On Tue, Feb 16, 2010 at 16:22, Johan Corveleyn wrote: > On Tue, Feb 16, 2010 at 8:15 PM, Greg Stein wrote: Instead, we could not store size and mtime at all! :) >>> >>> Or we could store both to perform simple consistency checks... >> >> Dunno about that, but the storage of SIZE is part of t

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Johan Corveleyn
On Tue, Feb 16, 2010 at 8:15 PM, Greg Stein wrote: >>> Instead, we could not store size and mtime at all! :) >> >> Or we could store both to perform simple consistency checks... > > Dunno about that, but the storage of SIZE is part of the (intended) > algorithm for pristine storage. It is allowed

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Mark Mielke
On 02/16/2010 03:24 PM, Mark Mielke wrote: On 02/16/2010 08:54 AM, Neels J Hofmeyr wrote: They are merely half-checks for validity. During normal operation, size and mtime should never change, because we don't open write streams to pristines. If anyone messes with the pristine store accidentall

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Mark Mielke
On 02/16/2010 08:54 AM, Neels J Hofmeyr wrote: They are merely half-checks for validity. During normal operation, size and mtime should never change, because we don't open write streams to pristines. If anyone messes with the pristine store accidentally, we would pick it up with the size, or if t

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Greg Stein
Meta-comment: all of these issues that you're bringing up are *exactly* why I wanted to punt the issue of external-to-WC stores out of 1.7. Keeping a 1:1 correspondence of pristine stores to working copies keeps the problem tractable, especially given all the other work that is needed. On Tue, Feb

RE: pristine store database -- was: pristine store design

2010-02-16 Thread Bert Huijben
> -Original Message- > From: Neels J Hofmeyr [mailto:ne...@elego.de] > Sent: dinsdag 16 februari 2010 14:55 > To: dev@subversion.apache.org > Cc: Philip Martin; Greg Stein; Hyrum Wright > Subject: pristine store database -- was: pristine store design > > Philip Martin wrote: > > Neels J Ho

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Neels J Hofmeyr
Commenting on myself... Neels J Hofmeyr wrote: > Philip Martin wrote: >> Neels J Hofmeyr writes: >> >>> THE PRISTINE STORE >>> == >>> >>> The pristine store is a local cache of complete content of files that are >>> known to be in the repository. It is hashed by a checksum of that