Re: misaligned blame output if repo has >1m revisions

2010-04-19 Thread Johan Corveleyn
2010/4/19 Julian Foad : > Johan Corveleyn wrote: >> On Sun, Apr 18, 2010 at 11:34 PM, Branko Čibej wrote: >> Instead why not do the following: >> > >> >    * Determining the max length for the revision number is a petty much >> >      constant-time operation; you either get it explicitly from blam

Re: misaligned blame output if repo has >1m revisions

2010-04-19 Thread Julian Foad
Johan Corveleyn wrote: > On Sun, Apr 18, 2010 at 11:34 PM, Branko Čibej wrote: > > Johan Corveleyn wrote: [...] > >> So, I'd like to do 3), and add just 1 (one) extra character for > >> revnum. With 1 extra character, we'd have up to 9,999,999 for revnum. > >> Even for http://websvn.kde.org/trunk/

Re: misaligned blame output if repo has >1m revisions

2010-04-19 Thread Johan Corveleyn
On Sun, Apr 18, 2010 at 11:34 PM, Branko Čibej wrote: > Johan Corveleyn wrote: >> Hi all, >> >> Sorry it took a while to respond (been away for a while). I've been >> thinking a little about this, looking at the code ... >> >> I see 3 options: >> >> 1) Determine the max length of revnum (and autho

Re: misaligned blame output if repo has >1m revisions

2010-04-18 Thread Branko Čibej
Johan Corveleyn wrote: > Hi all, > > Sorry it took a while to respond (been away for a while). I've been > thinking a little about this, looking at the code ... > > I see 3 options: > > 1) Determine the max length of revnum (and author) in blame.c, either > while building the blame chunks or in an

Re: misaligned blame output if repo has >1m revisions

2010-04-18 Thread Johan Corveleyn
Hi all, Sorry it took a while to respond (been away for a while). I've been thinking a little about this, looking at the code ... I see 3 options: 1) Determine the max length of revnum (and author) in blame.c, either while building the blame chunks or in an extra loop before sending the blame in

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Erik Huelsmann
Hi Philip, On Mon, Apr 12, 2010 at 3:14 PM, Philipp Marek wrote: > Hello Bert! > > On Montag, 12. April 2010, Bert Huijben wrote: >> Well, on Windows consoles are all 80 characters wide. (You can fix this if >> you are a frequent Command Prompt User, but most applications just assume >>  80 chara

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Philipp Marek
Hello Bert! On Montag, 12. April 2010, Bert Huijben wrote: > Well, on Windows consoles are all 80 characters wide. (You can fix this if > you are a frequent Command Prompt User, but most applications just assume > 80 characters on Windows. And in many cases Windows switches back to 80 > characte

RE: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Bert Huijben
> -Original Message- > From: Philipp Marek [mailto:philipp.ma...@emerion.com] > Sent: maandag 12 april 2010 14:43 > To: Hyrum K. Wright > Cc: dev; Erik Huelsmann; Stefan Sperling; Johan Corveleyn > Subject: Re: misaligned blame output if repo has >1m revisions >

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Philipp Marek
Hello Hyrum! On Montag, 12. April 2010, Hyrum K. Wright wrote: > On Mon, Apr 12, 2010 at 11:01 AM, Philipp Marek > > So 9 digits should buy a bit of time ;-) > Sure, but the more digits you put in, the more stuff gets pushed off the > back of the line. On a 80-character terminal, with code that's

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Hyrum K. Wright
On Mon, Apr 12, 2010 at 11:01 AM, Philipp Marek wrote: > Hello Erik! > > On Montag, 12. April 2010, Erik Huelsmann wrote: > > wrote: > > >http://websvn.kde.org/trunk/ > > >Directory revision: 1113881 > > With 3 additional spaces, that would fit, wouldn't it? > They're doing 100k

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Philipp Marek
Hello Erik! On Montag, 12. April 2010, Erik Huelsmann wrote: > wrote: > >http://websvn.kde.org/trunk/ > >Directory revision: 1113881 > With 3 additional spaces, that would fit, wouldn't it? They're doing 100k revisions in about 8 months: 1013930 => Fri Aug 21 09:33:02 20

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Erik Huelsmann
hi Phil, On Mon, Apr 12, 2010 at 7:54 AM, Philipp Marek wrote: > Hello Johan, > hello Stefan, > > On Freitag, 9. April 2010, Stefan Sperling wrote: >> On Fri, Apr 09, 2010 at 10:17:12PM +0200, Johan Corveleyn wrote: >> > So I guess this is coming up for you guys when s.a.o reaches the 1 >> > mill

Re: misaligned blame output if repo has >1m revisions

2010-04-11 Thread Philipp Marek
Hello Johan, hello Stefan, On Freitag, 9. April 2010, Stefan Sperling wrote: > On Fri, Apr 09, 2010 at 10:17:12PM +0200, Johan Corveleyn wrote: > > So I guess this is coming up for you guys when s.a.o reaches the 1 > > million mark :-). > > Nice buglet. I suppose we could simply add 2 or 3 spaces

Re: misaligned blame output if repo has >1m revisions

2010-04-09 Thread Hyrum K. Wright
On Fri, Apr 9, 2010 at 10:04 PM, Johan Corveleyn wrote: > On Fri, Apr 9, 2010 at 10:37 PM, Hyrum K. Wright > wrote: > > > > > > On Fri, Apr 9, 2010 at 9:17 PM, Johan Corveleyn > wrote: > >> > >> Hi devs, > >> > >> Just a heads up, not really important, but I came across this in > >> blame_cmd.c

Re: misaligned blame output if repo has >1m revisions

2010-04-09 Thread Stefan Sperling
On Fri, Apr 09, 2010 at 10:17:12PM +0200, Johan Corveleyn wrote: > Hi devs, > > Just a heads up, not really important, but I came across this in > blame_cmd.c (inside print_line_info): > > [[[ > const char *rev_str = SVN_IS_VALID_REVNUM(revision) > ? apr_psprintf(pool, "%6ld", revision) >

Re: misaligned blame output if repo has >1m revisions

2010-04-09 Thread Johan Corveleyn
On Fri, Apr 9, 2010 at 10:37 PM, Hyrum K. Wright wrote: > > > On Fri, Apr 9, 2010 at 9:17 PM, Johan Corveleyn wrote: >> >> Hi devs, >> >> Just a heads up, not really important, but I came across this in >> blame_cmd.c (inside print_line_info): >> >> [[[ >>  const char *rev_str = SVN_IS_VALID_REVN

Re: misaligned blame output if repo has >1m revisions

2010-04-09 Thread Hyrum K. Wright
On Fri, Apr 9, 2010 at 9:17 PM, Johan Corveleyn wrote: > Hi devs, > > Just a heads up, not really important, but I came across this in > blame_cmd.c (inside print_line_info): > > [[[ > const char *rev_str = SVN_IS_VALID_REVNUM(revision) >? apr_psprintf(pool, "%6ld", revision) >