Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 4:48 AM, Stefan Fritsch wrote: > I agree that the comments/documentation should be improved. I will write a > how-to for adjusting modules to the new API. Here is a constructive suggestion (*grin*): in APR, for some of the more complex declarations (see apr_pools.h and apr

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Stefan Fritsch
On Tue, 24 Aug 2010, Justin Erenkrantz wrote: In r951893, httpd modified a #define for APLOG_MARK to add in a new parameter called APLOG_MODULE_INDEX (in addition to file and line info). This busts Subversion - specifically, mod_authz_svn which has a function called: static void log_access_verd

RE: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Plüm, Rüdiger, VF-Group
> -Original Message- > From: Rainer Jung > Sent: Mittwoch, 25. August 2010 11:15 > To: d...@httpd.apache.org > Cc: Subversion Development > Subject: Re: httpd trunk broken with Subversion: ap_log_rerror busted > > On 25.08.2010 10:59, "P

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Rainer Jung
On 25.08.2010 10:59, "Plüm, Rüdiger, VF-Group" wrote: -Original Message- From: justin.erenkra...@gmail.com Yes, we could fix this by making mod_authz_svn conditional on the new MMN, but - again, it's about even figuring out that the API is changed and what to do about it. The root cau

RE: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Plüm, Rüdiger, VF-Group
> -Original Message- > From: justin.erenkra...@gmail.com > > Sent: Mittwoch, 25. August 2010 08:14 > To: d...@httpd.apache.org > Cc: Subversion Development > Subject: httpd trunk broken with Subversion: ap_log_rerror busted > > In r951893, httpd modified a #define for APLOG_MARK to ad