svnhooks program (was Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065))

2012-12-10 Thread Ivan Zhakov
On Mon, Dec 10, 2012 at 3:53 PM, Johan Corveleyn wrote: > On Mon, Dec 10, 2012 at 12:47 PM, Daniel Shahaf > wrote: [...] >> The argument is that a Subversion server should be enforcing >> Subversion's invariants. >> >> That said, I'm not opposed to doing it via standard hooks. It's a good >> w

RE: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-10 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: maandag 10 december 2012 8:04 > To: dev@subversion.apache.org > Subject: Re: enforcing LF-normalization for svn:eol-style=native files (issue > #4065) > > On 10.12.2012 07:35, Bert Hu

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-10 Thread Johan Corveleyn
On Mon, Dec 10, 2012 at 12:47 PM, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, Dec 10, 2012 at 11:51:08 +0100: >> On 10.12.2012 11:31, Daniel Shahaf wrote: >> > Branko Čibej wrote on Mon, Dec 10, 2012 at 00:26:20 +0100: >> >> On 10.12.2012 00:08, Johan Corveleyn wrote: >> >>> On Sun, Dec 9, 2

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-10 Thread Daniel Shahaf
Branko Čibej wrote on Mon, Dec 10, 2012 at 11:51:08 +0100: > On 10.12.2012 11:31, Daniel Shahaf wrote: > > Branko Čibej wrote on Mon, Dec 10, 2012 at 00:26:20 +0100: > >> On 10.12.2012 00:08, Johan Corveleyn wrote: > >>> On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf > >>> wrote: > Johan Cor

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-10 Thread Ivan Zhakov
On Mon, Dec 10, 2012 at 2:51 PM, Branko Čibej wrote: > On 10.12.2012 11:31, Daniel Shahaf wrote: >> Branko Čibej wrote on Mon, Dec 10, 2012 at 00:26:20 +0100: >>> On 10.12.2012 00:08, Johan Corveleyn wrote: On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf wrote: > Johan Corveleyn wro

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-10 Thread Branko Čibej
On 10.12.2012 11:31, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, Dec 10, 2012 at 00:26:20 +0100: >> On 10.12.2012 00:08, Johan Corveleyn wrote: >>> On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf >>> wrote: Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: > 2) Am I the

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-10 Thread Daniel Shahaf
Branko Čibej wrote on Mon, Dec 10, 2012 at 00:26:20 +0100: > On 10.12.2012 00:08, Johan Corveleyn wrote: > > On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf > > wrote: > >> Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: > >>> 2) Am I the only one who wants to protect his repository

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Branko Čibej
On 10.12.2012 07:35, Bert Huijben wrote: > I don’t think you have to wait until commit time: You could verify the > commit base revision’s properties + changes. In the cases where the > properties change before commit, the commit would fail for being out of > date. That would imply you can't chang

RE: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Bert Huijben
:* dev@subversion.apache.org *Subject:* Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065) On 10.12.2012 00:08, Johan Corveleyn wrote: > On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf wrote: >> Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: >>>

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Branko Čibej
On 10.12.2012 01:25, Johan Corveleyn wrote: > Another known offender is git-svn, because they don't care about > translating line termination. So if you use git-svn on Windows, you > might end up committing an eol-style=native file with CRLF's in to the > repository. Yuck. We should shout *really*

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Branko Čibej
On 10.12.2012 01:24, Stefan Fuhrmann wrote: > Well, if we really want to implement such a feature, > we may as well be a bit more clever about it: While > writing incoming file contents to the protrev file, we > may determine its NL style as we go and store the > result. The latter could then be co

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Johan Corveleyn
On Mon, Dec 10, 2012 at 12:26 AM, Branko Čibej wrote: > On 10.12.2012 00:08, Johan Corveleyn wrote: >> On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf >> wrote: >>> Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: 2) Am I the only one who wants to protect his repository against

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Stefan Fuhrmann
On Mon, Dec 10, 2012 at 12:26 AM, Branko Čibej wrote: > On 10.12.2012 00:08, Johan Corveleyn wrote: > > On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf > wrote: > >> Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: > >>> 2) Am I the only one who wants to protect his repository agains

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Branko Čibej
On 10.12.2012 00:21, Daniel Shahaf wrote: >> As for my 1st concern, about the slowness of the pre-commit hook >> validation, it might be possible to make it faster if both 'svnlook >> pg' and 'svnlook cat' would support multiple targets. > Or if you wrote your hook script using the Python bindings.

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Branko Čibej
On 10.12.2012 00:08, Johan Corveleyn wrote: > On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf > wrote: >> Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: >>> 2) Am I the only one who wants to protect his repository against this >>> corruption? Judging from [1], I don't think so. It d

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Daniel Shahaf
Johan Corveleyn wrote on Mon, Dec 10, 2012 at 00:08:26 +0100: > On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf > wrote: > > Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: > >> 2) Am I the only one who wants to protect his repository against this > >> corruption? Judging from [1], I

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Johan Corveleyn
On Sun, Dec 9, 2012 at 11:43 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: >> 2) Am I the only one who wants to protect his repository against this >> corruption? Judging from [1], I don't think so. It doesn't make sense >> that everyone starts writing th

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Daniel Shahaf
Johan Corveleyn wrote on Sun, Dec 09, 2012 at 21:15:24 +0100: > 2) Am I the only one who wants to protect his repository against this > corruption? Judging from [1], I don't think so. It doesn't make sense > that everyone starts writing this pre-commit hook, for something that > IMHO is an obvious

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Johan Corveleyn
On Sun, Dec 9, 2012 at 11:42 AM, Branko Čibej wrote: > On 09.12.2012 09:14, Daniel Shahaf wrote: >> Johan Corveleyn wrote on Sun, Dec 09, 2012 at 01:02:55 +0100: >>> Last week a colleague managed to commit a non-LF-normalized >>> svn:eol-style=native file in our repository again. As explained in >

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Branko Čibej
On 09.12.2012 09:14, Daniel Shahaf wrote: > Johan Corveleyn wrote on Sun, Dec 09, 2012 at 01:02:55 +0100: >> Last week a colleague managed to commit a non-LF-normalized >> svn:eol-style=native file in our repository again. As explained in >> issue #4065 [1], this causes all kinds of problems. >> >>

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

2012-12-09 Thread Daniel Shahaf
Johan Corveleyn wrote on Sun, Dec 09, 2012 at 01:02:55 +0100: > Last week a colleague managed to commit a non-LF-normalized > svn:eol-style=native file in our repository again. As explained in > issue #4065 [1], this causes all kinds of problems. > > I suspect there might be a bug in SVNKit, some