Re: The patch-exec branch

2015-08-08 Thread Daniel Shahaf
Branko Čibej wrote on Sat, Aug 01, 2015 at 09:43:25 +0200: > And FWIW, we should ignore the read-write perms from Git diffs and only > (try to) tweak the executable bit. That's what the code is doing and I have no plans to change it. The 'apply mode changes' part is done. If anyone wants to revi

Re: The patch-exec branch

2015-08-01 Thread Branko Čibej
On 01.08.2015 09:24, Greg Stein wrote: > On Fri, Jul 31, 2015 at 6:36 PM, Daniel Shahaf > wrote: > >... > > Two questions: > > - When one side of the diff is in the OS filesystem, do we still fold > its value to 644/755 for output? > > - If yes, ho

Re: The patch-exec branch

2015-08-01 Thread Greg Stein
On Fri, Jul 31, 2015 at 6:36 PM, Daniel Shahaf wrote: >... > Two questions: > > - When one side of the diff is in the OS filesystem, do we still fold > its value to 644/755 for output? > > - If yes, how do we choose between 644 and 755? (e.g., do we use > "x & 0111 == 0111", or "x & 0100 ==

Re: The patch-exec branch

2015-07-31 Thread Daniel Shahaf
Julian Foad wrote on Wed, Jul 29, 2015 at 16:22:27 +0100: > Daniel Shahaf wrote: > > In a nutshell, the purpose of the branch is to make 'svn patch' set > > svn:exeutable when processing a patch such as: > > > > diff --git a/iota b/iota > > old mode 100644 > > new mode 100755 > > > The

Re: The patch-exec branch

2015-07-29 Thread Julian Foad
Daniel Shahaf wrote: > In a nutshell, the purpose of the branch is to make 'svn patch' set > svn:exeutable when processing a patch such as: > > diff --git a/iota b/iota > old mode 100644 > new mode 100755 > The unit tests changes (in parse-diff-test.c and patch_tests.py) give > a full

Re: The patch-exec branch

2015-07-27 Thread Daniel Shahaf
Branko Čibej wrote on Sun, Jul 26, 2015 at 17:50:43 +0200: > On 26.07.2015 14:07, Daniel Shahaf wrote: > > danie...@apache.org wrote on Sun, Jul 26, 2015 at 12:01:57 -: > >> Author: danielsh > >> Date: Sun Jul 26 12:01:56 2015 > >> New Revision: 1692721 > >> > >> URL: http://svn.apache.org/r169

Re: The patch-exec branch

2015-07-26 Thread Branko Čibej
On 26.07.2015 14:07, Daniel Shahaf wrote: > danie...@apache.org wrote on Sun, Jul 26, 2015 at 12:01:57 -: >> Author: danielsh >> Date: Sun Jul 26 12:01:56 2015 >> New Revision: 1692721 >> >> URL: http://svn.apache.org/r1692721 >> Log: >> On the patch-exec branch, add BRANCH-README. >> >> Added: