Re: Static code analysis (cppcheck)

2011-06-30 Thread Daniel Shahaf
Bolstridge, Andrew wrote on Thu, Jun 30, 2011 at 08:44:41 +: > (all in chapter 6 of the manual) Nonetheless, thanks for summarizing that here. I for one don't read the manual of every tool mentioned on the list :-)

Re: Static code analysis (cppcheck)

2011-06-30 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: > > >> To remove the warning I suppose we could drop the app variable, i.e. > >> > >>new QCoreApplication(...) > >> > >> instead of > >> > >>app = new QCoreApplication(...) > >> > >> but that might prompt other warnings. > > > > The e

Re: Static code analysis (cppcheck)

2011-06-30 Thread Philip Martin
Julian Foad writes: >> To remove the warning I suppose we could drop the app variable, i.e. >> >>new QCoreApplication(...) >> >> instead of >> >>app = new QCoreApplication(...) >> >> but that might prompt other warnings. > > The existing code creates the object and (though it

Re: Static code analysis (cppcheck)

2011-06-30 Thread Julian Foad
On Wed, 2011-06-29 at 17:39 +0100, Philip Martin wrote: > Julian Foad writes: > > >> [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable > >> 'app' > >> is assigned a value that is never used > >> [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable > >> 'ap

RE: Static code analysis (cppcheck)

2011-06-30 Thread Bolstridge, Andrew
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: 29 June 2011 17:39 > To: Julian Foad > Cc: Philipp Kloke; Hyrum K Wright; dev@subversion.apache.org > Subject: Re: Static code analysis (cppcheck) > > Julian Foad writes:

Re: Static code analysis (cppcheck)

2011-06-29 Thread Philip Martin
Julian Foad writes: >> [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app' >> is assigned a value that is never used >> [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable 'app' >> is assigned a value that is never used > > I don't really understand the

Re: Static code analysis (cppcheck)

2011-06-29 Thread Julian Foad
Philipp Kloke wrote: > [SVN\subversion\bindings\javahl\native\JNIUtil.h:40] -> > [SVN\subversion\include\svn_types.h:132]: (style) Struct 'svn_error_t' > forward declaration unnecessary, already declared [...] > [SVN\subversion\include\private\svn_temp_serializer.h:42] -> > [SVN\subversion\includ

Re: Static code analysis (cppcheck)

2011-06-29 Thread Philipp Kloke
: Static code analysis (cppcheck) Philipp, Thanks for the analysis. I've made several commits which address the issues in your log. Feel free to re-run to ensure that they were fixed. Thanks, -Hyrum On Tue, Jun 28, 2011 at 12:31 PM, Philipp Kloke wrote: Hi, I checked the sourceco

Re: Static code analysis (cppcheck)

2011-06-28 Thread Hyrum K Wright
Philipp, Thanks for the analysis. I've made several commits which address the issues in your log. Feel free to re-run to ensure that they were fixed. Thanks, -Hyrum On Tue, Jun 28, 2011 at 12:31 PM, Philipp Kloke wrote: > Hi, > > I checked the sourcecode of subversion (r1140736) with cppcheck.