Re: Segmentation fault during diff generation

2014-09-02 Thread Julian Foad
I (Julian Foad) wrote: >>  Thanks. r1621978. (That's almost exactly the patch I posted here, but after >>  I cleaned up some unused variables and obsolete comments.) > > Simplified, and removed a stray debug print, in r1621981. Nominated for backport to 1.8.x in 1622023. - Julian

Re: Segmentation fault during diff generation

2014-09-02 Thread Julian Foad
I (Julian Foad) wrote: > Thanks. r1621978. (That's almost exactly the patch I posted here, but after > I cleaned up some unused variables and obsolete comments.) Simplified, and removed a stray debug print, in r1621981. - Julian

Re: Segmentation fault during diff generation

2014-09-02 Thread Julian Foad
Bert Huijben wrote: >> So here, attached, is an implementation of the post-filtering approach. >> This is implemented using a common filter for repos-WC and WC-WC diffs. >> [...] > > I really like this approach. > > I think we should commit it and improve from there. (I can't see why it > would b

RE: Segmentation fault during diff generation

2014-09-02 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: dinsdag 2 september 2014 13:45 > To: Bert Huijben > Cc: 'Peter Galcik'; dev@subversion.apache.org > Subject: Re: Segmentation fault during diff generation > > I (Ju

Re: Segmentation fault during diff generation

2014-09-02 Thread Julian Foad
I (Julian Foad) wrote: > The attached brute-force patch seems to fix many of the cases where > changelist > filtering was missing or wrong, but I don't much like it and haven't > properly tested it. So here, attached, is an implementation of the post-filtering approach. This is implemented usi

Re: Segmentation fault during diff generation

2014-09-01 Thread Julian Foad
The attached brute-force patch seems to fix many of the cases where changelist filtering was missing or wrong, but I don't much like it and haven't properly tested it. I'm attaching it for us to consider, but not necessarily to commit. If anyone wants to kick it around a bit (test it) and repor

RE: Segmentation fault during diff generation

2014-09-01 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: maandag 1 september 2014 15:59 > To: Peter Galcik > Cc: dev@subversion.apache.org > Subject: Re: Segmentation fault during diff generation > (In the longer term, I would like it

Re: Segmentation fault during diff generation

2014-09-01 Thread Julian Foad
Peter Galcik wrote: > I am using SVN on Solaris platform (svn, version 1.8.5 [...]) and Windows > (svn, version 1.8.10 [...]) with changelist feature. > > Normal svn diff command without changelist go well but when valid changelist > is passed to command, crash occurs. Hi Peter. Thank you for thi