Re: Review Request: svn.fs.FileDiff

2018-02-12 Thread Troy Curtis Jr
On Sun, Feb 11, 2018 at 4:33 PM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +: > > I'm asking for comments because the actual diff output given when > > 'diffoptions' is None, is changed. > ... > > Thoughts? > > 1. We have two consumers of FileDiff in tools/. Check

Re: Review Request: svn.fs.FileDiff

2018-02-11 Thread Daniel Shahaf
Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +: > I'm asking for comments because the actual diff output given when > 'diffoptions' is None, is changed. ... > Thoughts? 1. We have two consumers of FileDiff in tools/. Check whether they are affected? 2. We might include the change in an a