Re: New canonicalization functions [was: Subversion Exception!]

2018-12-15 Thread Branko Čibej
On 15.12.2018 12:24, Branko Čibej wrote: > On 14.12.2018 19:05, Branko Čibej wrote: >> On Fri, 14 Dec 2018, 18:14 Julian Foad > >>> Julian Foad wrote: Are you willing to add random-input testing for them? >>> The attached patch 'dirent-uri-test-random-2.patch' tests rules like: >>> >>> * eve

Re: New canonicalization functions [was: Subversion Exception!]

2018-12-15 Thread Branko Čibej
On 14.12.2018 19:05, Branko Čibej wrote: > On Fri, 14 Dec 2018, 18:14 Julian Foad >> Julian Foad wrote: >>> Are you willing to add random-input testing for them? >> The attached patch 'dirent-uri-test-random-2.patch' tests rules like: >> >> * every result should pass an X_is_canonical() test (ob

Re: New canonicalization functions [was: Subversion Exception!]

2018-12-14 Thread Julian Foad
Branko Čibej wrote: > What inconsistencies? A canonical URI has the scheme and host name in > lowercase, but the path, query, fragment and user info parts are case- > sensitive.> > Similarly, I think we (or APR?) make drive letters lowercase. In both cases I found examples where is_canonical said

Re: New canonicalization functions [was: Subversion Exception!]

2018-12-14 Thread Branko Čibej
On Fri, 14 Dec 2018, 18:14 Julian Foad Julian Foad wrote: > > Are you willing to add random-input testing for them? > > The attached patch 'dirent-uri-test-random-2.patch' tests rules like: > > * every result should pass an X_is_canonical() test (obvious by code > inspection); > * every other

Re: New canonicalization functions [was: Subversion Exception!]

2018-12-14 Thread Branko Čibej
On Fri, 14 Dec 2018, 16:18 Julian Foad Branko Čibej wrote: > > r1848943, for review. [...] > > Woo hoo! Thanks, Brane. > > Are you willing to add random-input testing for them? > > Minor comments: > * the 'relpath' one is not needed because, AFAIK, it's possible to > canonicalize any relpath and

Re: New canonicalization functions [was: Subversion Exception!]

2018-12-14 Thread Julian Foad
Julian Foad wrote: > Are you willing to add random-input testing for them? The attached patch 'dirent-uri-test-random-2.patch' tests rules like: * every result should pass an X_is_canonical() test (obvious by code inspection); * every other input should produce SVN_ERR_CANONICALIZATION_FAILE

Re: New canonicalization functions [was: Subversion Exception!]

2018-12-14 Thread Julian Foad
Branko Čibej wrote: > r1848943, for review. [...] Woo hoo! Thanks, Brane. Are you willing to add random-input testing for them? Minor comments: * the 'relpath' one is not needed because, AFAIK, it's possible to canonicalize any relpath and we already do; * the non-canonical 'result' and scr