Re: Literals in wc SQLite queries

2012-12-11 Thread Philip Martin
Philip Martin writes: > I see no reason why we should not introduce a depth map and use > svn_sqlite__column_token instead. For both 1.7 and 1.8 an excluded file has null depth: $ rm -rf wc && svn co file://`pwd`/repo wc $ svn up --set-depth exclude wc/A/f $ sqlite3 -nullvalue - wc/.svn/wc.db "

Re: Literals in wc SQLite queries

2012-12-11 Thread Philip Martin
Philip Martin writes: > Daniel Shahaf writes: > >> Philip Martin wrote on Mon, Dec 10, 2012 at 17:49:44 +: >>> Daniel Shahaf writes: >>> >>> > Philip - perhaps you can move the relevant definitions to that header? >>> > Then I'll follow up with a transform_sql.py patch. >>> >>> OK, I've d

Re: Literals in wc SQLite queries

2012-12-11 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Mon, Dec 10, 2012 at 17:49:44 +: >> Daniel Shahaf writes: >> >> > Philip - perhaps you can move the relevant definitions to that header? >> > Then I'll follow up with a transform_sql.py patch. >> >> OK, I've done that. I didn't annotate the m

Re: Literals in wc SQLite queries

2012-12-10 Thread Daniel Shahaf
Philip Martin wrote on Mon, Dec 10, 2012 at 17:49:44 +: > Daniel Shahaf writes: > > > Philip - perhaps you can move the relevant definitions to that header? > > Then I'll follow up with a transform_sql.py patch. > > OK, I've done that. I didn't annotate the maps or elements in any way. Imp

Re: Literals in wc SQLite queries

2012-12-10 Thread Philip Martin
Daniel Shahaf writes: > Philip - perhaps you can move the relevant definitions to that header? > Then I'll follow up with a transform_sql.py patch. OK, I've done that. I didn't annotate the maps or elements in any way. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.

Re: Literals in wc SQLite queries

2012-12-10 Thread Daniel Shahaf
As I said on IRC, happy to look into this, my main question is how transform_sql.py would know what files to scan for the MAP_DELETED <-> 'base-deleted' mappings. Do we want a header file with a well-known name (subversion/include/private/)? Maybe in the same directory as the source .sql file? M

Re: Literals in wc SQLite queries

2012-12-07 Thread Julian Foad
Greg Stein wrote: > That sounds like a great idea! +1 > > It shouldn't be hard to tweak transform_sql.py. If you have a specific > prefix for the "token" symbols (eg TOKEN_BASE_DELETED), then we can > have the transform script simply look for lines like you suggest in > (say) wc_db.h. If the sear

Re: Literals in wc SQLite queries

2012-12-07 Thread Greg Stein
That sounds like a great idea! +1 It shouldn't be hard to tweak transform_sql.py. If you have a specific prefix for the "token" symbols (eg TOKEN_BASE_DELETED), then we can have the transform script simply look for lines like you suggest in (say) wc_db.h. If the search regex is strong enough, then