Re: JavaHL problem with NativeException

2022-07-29 Thread Daniel Sahlberg
Den fre 29 juli 2022 kl 16:29 skrev Branko Čibej : > On 27.07.2022 22:18, Daniel Sahlberg wrote: > > Den tis 26 juli 2022 kl 10:55 skrev Branko Čibej : > >> On 15.07.2022 23:19, Daniel Sahlberg wrote: >> > Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer >> > : >> > >> > Hi SVN developers, >>

Re: JavaHL problem with NativeException

2022-07-29 Thread Branko Čibej
On 27.07.2022 22:18, Daniel Sahlberg wrote: Den tis 26 juli 2022 kl 10:55 skrev Branko Čibej : On 15.07.2022 23:19, Daniel Sahlberg wrote: > Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer > : > >     Hi SVN developers, > > > Hi Thomas, > > Thanks for th

Re: JavaHL problem with NativeException

2022-07-27 Thread Daniel Sahlberg
Den lör 16 juli 2022 kl 23:11 skrev James McCoy : > On Sat, Jul 16, 2022 at 10:49:50PM +0200, Daniel Sahlberg wrote: > > dev@: I would prefer to commit this in two separate commits, first the > test > > cases and second the fix. But I could not find any way to "XFail" the > test > > case. > > You

Re: JavaHL problem with NativeException

2022-07-27 Thread Daniel Sahlberg
Den tis 26 juli 2022 kl 10:55 skrev Branko Čibej : > On 15.07.2022 23:19, Daniel Sahlberg wrote: > > Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer > > : > > > > Hi SVN developers, > > > > > > Hi Thomas, > > > > Thanks for the detailed report! > > > > First, there are 2 classes of Nativ

Re: JavaHL problem with NativeException

2022-07-27 Thread Daniel Sahlberg
Hi, Sorry for the late reply! I've changed according to your suggestion, the test fails with a NullPointerException without the fix so at least it will test the previous error. [[[ Index: subversion/bindings/javahl/src/org/apache/subversion/javahl/NativeException.java ===

Re: JavaHL problem with NativeException

2022-07-26 Thread Branko Čibej
On 15.07.2022 23:19, Daniel Sahlberg wrote: Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer : Hi SVN developers, Hi Thomas, Thanks for the detailed report! First, there are 2 classes of NativeException, one in org.tigris.subversion.javahl package, the other in org.apache.s

Re: JavaHL problem with NativeException

2022-07-18 Thread Thomas Singer
Hi Daniel, Thanks for the quick investigation. I would simplify the test: @Test public void testGetMessage() { assertEquals("", new NativeException(null, null, null, 0).getMessage()); assertEquals("messagesvn: source: )apr_err=0)", new NativeExc

Re: JavaHL problem with NativeException

2022-07-16 Thread James McCoy
On Sat, Jul 16, 2022 at 10:49:50PM +0200, Daniel Sahlberg wrote: > dev@: I would prefer to commit this in two separate commits, first the test > cases and second the fix. But I could not find any way to "XFail" the test > case. You can use junit's Ignore annotation. [[[ import org.junit.Ignore; .

Re: JavaHL problem with NativeException

2022-07-16 Thread Daniel Sahlberg
Den fre 15 juli 2022 kl 23:19 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer < > thomas.sin...@syntevo.com>: > >> Hi SVN developers, >> > > Hi Thomas, > > Thanks for the detailed report! > > >> First, there are 2 classes of NativeException

Re: JavaHL problem with NativeException

2022-07-15 Thread Daniel Sahlberg
Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer : > Hi SVN developers, > Hi Thomas, Thanks for the detailed report! > First, there are 2 classes of NativeException, one in > org.tigris.subversion.javahl package, the other in > org.apache.subversion.javahl package. They only slightly differ i