Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-17 Thread Julian Foad
Branko Čibej wrote: > On 17.12.2014 17:13, Julian Foad wrote: >>   * 'svnadmin load' always rewrites mergeinfo, which can change its form >> even if it doesn't need to change it semantically. (Except, since >> r1643074, if it's unparsable, it loads it unchanged instead of bombing >> out.) >> >>

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-17 Thread Branko Čibej
On 17.12.2014 17:13, Julian Foad wrote: > Branko Čibej wrote: >> On 17.12.2014 15:52, Julian Foad wrote: >>> In http://svn.apache.org/r1646250 I committed a version that also works by >>> textual substitution, but (hopefully) without the above-mentioned issues. >>> This >>> makes svnsync remove

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-17 Thread Julian Foad
Branko Čibej wrote: > On 17.12.2014 15:52, Julian Foad wrote: >> In http://svn.apache.org/r1646250 I committed a version that also works by >> textual substitution, but (hopefully) without the above-mentioned issues. >> This >> makes svnsync remove r0 references before trying to commit. > > Doe

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-17 Thread Branko Čibej
On 17.12.2014 15:52, Julian Foad wrote: > I (Julian Foad) wrote on 4th December: >> Julian Foad wrote: >>> ... 'svnsync' ... my current thought is it >>> should 'correct' the mergeinfo by removing the r0 reference. >> I have written a test for this, and hacked up code to do this by textual >> s

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-17 Thread Julian Foad
I (Julian Foad) wrote on 4th December: > Julian Foad wrote: >> ... 'svnsync' ... my current thought is it >>  should 'correct' the mergeinfo by removing the r0 reference. > > I have written a test for this, and hacked up code to do this by textual > substitution. It isn't quite right -- for exam

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-04 Thread Julian Foad
[Second attempt to attach the patch.] I (Julian Foad) wrote: >> I'll come to 'svnsync' later, but basically my current thought is it >> should 'correct' the mergeinfo by removing the r0 reference. > > I have written a test for this, and hacked up code to do this by textual > substitution. It is

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-04 Thread Branko Čibej
On 04.12.2014 19:40, Julian Foad wrote: > I (Julian Foad) wrote: > >>> I'll come to 'svnsync' later, but basically my current thought is it >>> should 'correct' the mergeinfo by removing the r0 reference. >> I have written a test for this, and hacked up code to do this by textual >> substitutio

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-04 Thread Julian Foad
I (Julian Foad) wrote: >> I'll come to 'svnsync' later, but basically my current thought is it >> should 'correct' the mergeinfo by removing the r0 reference. > > I have written a test for this, and hacked up code to do this by textual > substitution. It isn't quite right -- for example it wo

Re: Issue #4476 - Mergeinfo containing r0 makes svnsync and svnadmin dump fail

2014-12-04 Thread Julian Foad
Julian Foad wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=4476 [...] > PROPOSAL > > In the presence of a mergeinfo property that refers to r0, at the > libsvn_repos > API: > > 'dump' >   shall dump the property verbatim (with nowarning). (Done.) > > 'load', with 'validate proper