Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Blair Zajac
On 04/18/2012 12:15 AM, Julian Foad wrote: Blair Zajac wrote: In case of an illegal svn_checksum_kind_t being passed to svn_checksum__from_digest(), I want to change it from svn_checksum_t * svn_checksum__from_digest(const unsigned char *digest, svn_checksum_kind_t k

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 09:47, Hyrum K Wright wrote: > On Wed, Apr 18, 2012 at 8:18 AM, Julian Foad > wrote: >... >> In response to consistency: after writing the above I've just realized why >> this function really is different from the others.  Most of the checksum >> functions that take a '

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Hyrum K Wright
On Wed, Apr 18, 2012 at 8:18 AM, Julian Foad wrote: > Hyrum K Wright wrote: > >> On Wed, Apr 18, 2012 at 2:15 AM, Julian Foad wrote: >>>  Blair Zajac wrote:  In case of an illegal svn_checksum_kind_t being passed to  svn_checksum__from_digest(), I want to change it from  svn_ch

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Julian Foad
Hyrum K Wright wrote: > On Wed, Apr 18, 2012 at 2:15 AM, Julian Foad wrote: >> Blair Zajac wrote: >>> In case of an illegal svn_checksum_kind_t being passed to >>> svn_checksum__from_digest(), I want to change it from >>> >>> svn_checksum_t * >>> svn_checksum__from_digest(const unsigned char

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Hyrum K Wright
On Wed, Apr 18, 2012 at 2:15 AM, Julian Foad wrote: > Blair Zajac wrote: > >> In case of an illegal svn_checksum_kind_t being passed to >> svn_checksum__from_digest(), I want to change it from >> >> svn_checksum_t * >> svn_checksum__from_digest(const unsigned char *digest, >>                      

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Julian Foad
Blair Zajac wrote: > In case of an illegal svn_checksum_kind_t being passed to > svn_checksum__from_digest(), I want to change it from > > svn_checksum_t * > svn_checksum__from_digest(const unsigned char *digest, >                           svn_checksum_kind_t kind, >                           a

Re: Changing svn_checksum__from_digest()'s signature

2012-04-17 Thread Greg Stein
On Apr 18, 2012 1:05 AM, "Blair Zajac" wrote: > > In case of an illegal svn_checksum_kind_t being passed to svn_checksum__from_digest(), I want to change it from > > svn_checksum_t * > svn_checksum__from_digest(const unsigned char *digest, > svn_checksum_kind_t kind, >