Re: COPY_TWO_BYTES and C strict aliasing

2012-06-04 Thread Stefan Fuhrmann
Am 01.06.2012 14:22, schrieb Philip Martin: GCC gives a compiler warning where the COPY_TWO_BYTES macro is used. A typical warning is: ../src/subversion/libsvn_subr/string.c:971:11: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] COPY

Re: COPY_TWO_BYTES and C strict aliasing

2012-06-02 Thread Branko Čibej
On 01.06.2012 19:24, Philip Martin wrote: > Philip Martin writes: > >> Is COPY_TWO_BYTES a significant optimisation? > r1325896 implies this is most significant for ra_svn. So I compared the > testsuite over ra_svn built with the "fast" code and the "slow" code. > The CPU used by the testsuite an

Re: COPY_TWO_BYTES and C strict aliasing

2012-06-01 Thread Philip Martin
Philip Martin writes: > Is COPY_TWO_BYTES a significant optimisation? r1325896 implies this is most significant for ra_svn. So I compared the testsuite over ra_svn built with the "fast" code and the "slow" code. The CPU used by the testsuite and svnserve was: "fast" code 749.93user 404.

Re: COPY_TWO_BYTES and C strict aliasing

2012-06-01 Thread Philip Martin
Branko Čibej writes: > On 01.06.2012 14:22, Philip Martin wrote: >> GCC gives a compiler warning where the COPY_TWO_BYTES macro is used. A >> typical warning is: >> >> ../src/subversion/libsvn_subr/string.c:971:11: warning: dereferencing >> type-punned pointer will break strict-aliasing rules [

Re: COPY_TWO_BYTES and C strict aliasing

2012-06-01 Thread Branko Čibej
On 01.06.2012 14:22, Philip Martin wrote: > GCC gives a compiler warning where the COPY_TWO_BYTES macro is used. A > typical warning is: > > ../src/subversion/libsvn_subr/string.c:971:11: warning: dereferencing > type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] >