Re: 1.10 API review - svn_io_stdin_readline()

2018-01-16 Thread Stefan Sperling
On Tue, Jan 16, 2018 at 09:36:42AM +, Julian Foad wrote: > Stefan Sperling wrote: > > On Tue, Jan 16, 2018 at 07:37:31AM +0100, Branko Čibej wrote: > > > 2. What's wrong with using svn_stream_readline() with > > > svn_io_stream_for_stdin2()? > > > > > > In other words: I suspect this new funct

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-16 Thread Julian Foad
Stefan Sperling wrote: On Tue, Jan 16, 2018 at 07:37:31AM +0100, Branko Čibej wrote: 2. What's wrong with using svn_stream_readline() with svn_io_stream_for_stdin2()? In other words: I suspect this new function should be removed. [...] This function is in fact just a convenience wrapper arou

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-16 Thread Stefan Sperling
On Tue, Jan 16, 2018 at 07:37:31AM +0100, Branko Čibej wrote: > Two questions here: > 1. Why did none of the existing functions in libsvn_subr/prompt.c fit > the use case? They assume a terminal. I'm not sure if they'd work on stdin as-is. > 2. What's wrong with using svn_stream_readline() with >

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Branko Čibej
On 15.01.2018 22:22, Stefan Sperling wrote: > On Mon, Jan 15, 2018 at 04:42:02PM +, Julian Foad wrote: >> About this new-for-1.10 API: >> [[[ >> /** Reads a string from stdin until a newline or EOF is found >> * >> * @since New in 1.10. >> */ >> svn_error_t * >> svn_io_stdin_readline(const c

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Branko Čibej
On 16.01.2018 03:42, Nathan Hartman wrote: >> On Jan 15, 2018, at 11:42 AM, Julian Foad wrote: >> >> About this new-for-1.10 API: >> [[[ >> /** Reads a string from stdin until a newline or EOF is found >> * >> * @since New in 1.10. >> */ >> svn_error_t * >> svn_io_stdin_readline(const char **resul

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Nathan Hartman
> On Jan 15, 2018, at 11:42 AM, Julian Foad wrote: > > About this new-for-1.10 API: > [[[ > /** Reads a string from stdin until a newline or EOF is found > * > * @since New in 1.10. > */ > svn_error_t * > svn_io_stdin_readline(const char **result, > apr_pool_t *result_pool, >

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Stefan Sperling
On Mon, Jan 15, 2018 at 04:42:02PM +, Julian Foad wrote: > About this new-for-1.10 API: > [[[ > /** Reads a string from stdin until a newline or EOF is found > * > * @since New in 1.10. > */ > svn_error_t * > svn_io_stdin_readline(const char **result, > apr_pool_t *resu