Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-21 Thread Stefan Sperling
On Sat, Sep 20, 2014 at 12:37:39PM -0500, Greg Stein wrote: > On Wed, Sep 10, 2014 at 12:24 PM, C. Michael Pilato > wrote: > > > On 09/10/2014 01:06 PM, Stefan Sperling wrote: > > > I've been working on the log-message-templates branch recently. > > > This branch was started by cmpilato a long ti

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-20 Thread Greg Stein
On Wed, Sep 10, 2014 at 12:24 PM, C. Michael Pilato wrote: > On 09/10/2014 01:06 PM, Stefan Sperling wrote: > > I've been working on the log-message-templates branch recently. > > This branch was started by cmpilato a long time ago but for some > > reason sat around untouched ever since. It's now

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-16 Thread Branko Čibej
On 16.09.2014 11:14, Julian Foad wrote: > Stefan Sperling wrote: >> On Mon, Sep 15, 2014 at 03:56:07PM +0100, Julian Foad wrote: >> http://stackoverflow.com/questions/983026/how-do-i-create-a-svn-commit-message-template-and-hook-to-verify >>> The script in the answer by JoeRandomUser highlights a

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-16 Thread Julian Foad
Stefan Sperling wrote: > On Mon, Sep 15, 2014 at 03:56:07PM +0100, Julian Foad wrote: > http://stackoverflow.com/questions/983026/how-do-i-create-a-svn-commit-message-template-and-hook-to-verify >> >>  The script in the answer by JoeRandomUser highlights a problem with putting >>  template text ab

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-16 Thread Stefan Sperling
On Mon, Sep 15, 2014 at 03:37:22PM -0700, Alexey Neyman wrote: > On Monday, September 15, 2014 10:25:42 AM Julian Foad wrote: > ... snip ... > > Instead of a 'get_log_message(list_of_commit_items)' we should have > > 'get_rev_props_for_commit(list_of_commit_items)', and instead of a template > > we

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Alexey Neyman
On Monday, September 15, 2014 10:25:42 AM Julian Foad wrote: ... snip ... > Instead of a 'get_log_message(list_of_commit_items)' we should have > 'get_rev_props_for_commit(list_of_commit_items)', and instead of a template > we should have: > > - a list of required and optional rev-props (usually

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Stefan Sperling
On Mon, Sep 15, 2014 at 03:56:07PM +0100, Julian Foad wrote: > Johan Corveleyn wrote: > > http://stackoverflow.com/questions/983026/how-do-i-create-a-svn-commit-message-template-and-hook-to-verify > > The script in the answer by JoeRandomUser highlights a problem with putting > template text above

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Branko Čibej
On 15.09.2014 16:43, Julian Foad wrote: > Hi Brane. > > Isn't this fun, brainstorming a new feature (re)design? > > Your proposal contains good points about adding a format number and a comment > syntax as well as an extensible command syntax. > > Branko Čibej wrote: >> On 15.09.2014 11:25, Julian

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Julian Foad
Johan Corveleyn wrote: > On Mon, Sep 15, 2014 at 12:58 PM, Stefan Sperling wrote: >... >>> Are there other examples "out there" like FreeBSD but different? >> >> I don't know. I was hoping to get something finished that satisfies the >> FreeBSD use case, and nothing else. They obviously have a nee

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Julian Foad
Hi Brane. Isn't this fun, brainstorming a new feature (re)design? Your proposal contains good points about adding a format number and a comment syntax as well as an extensible command syntax. Branko Čibej wrote: > On 15.09.2014 11:25, Julian Foad wrote: >> [...] We will want to upgrade the >> f

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Branko Čibej
On 15.09.2014 11:25, Julian Foad wrote: >> And perhaps we could introduce a template syntax to specify >> key-value pairs (e.g. "%KEYWORD:%") which are removed automatically >> if the value is left empty? [...] > UPGRADE PATHS > > Once we release this, the 'svn:log-template' property will exist i

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Johan Corveleyn
On Mon, Sep 15, 2014 at 12:58 PM, Stefan Sperling wrote: ... >> Are there other examples "out there" like FreeBSD but different? > > I don't know. I was hoping to get something finished that satisfies the > FreeBSD use case, and nothing else. They obviously have a need for this, > else they wouldn

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Julian Foad
Stefan Sperling wrote: > On Mon, Sep 15, 2014 at 10:25:42AM +0100, Julian Foad wrote: >> I recommend we anticipate this now by defining a minimal syntax for >> substitutions. > > Whatever we come up with now might not fit a future substitution feature. > I'd say either we define the feature compl

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Stefan Sperling
On Mon, Sep 15, 2014 at 10:25:42AM +0100, Julian Foad wrote: > The FreeBSD patch provides two things to the user. It provides a template to > be filled in, and it also provides a help message describing how to do so. I > think we need to recognize that these are different. (And we should not > mere

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Julian Foad
Stefan Sperling wrote: > On Mon, Sep 15, 2014 at 08:58:37AM +0100, Julian Foad wrote: >> Justin Erenkrantz wrote: >>> If the functionality follows what is described above, my only request >>> is that we insert the template/property value *after* the ignore line >>> - I don't think that these templa

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Stefan Sperling
On Mon, Sep 15, 2014 at 08:58:37AM +0100, Julian Foad wrote: > Justin Erenkrantz wrote: > > On Wed, Sep 10, 2014 at 1:06 PM, Stefan Sperling wrote: > >>  I believe the functionality is useful and complete. One user I have > >>  in mind who would probably make use of this is the FreeBSD project. >

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-15 Thread Julian Foad
Justin Erenkrantz wrote: > On Wed, Sep 10, 2014 at 1:06 PM, Stefan Sperling wrote: >>  I believe the functionality is useful and complete. One user I have >>  in mind who would probably make use of this is the FreeBSD project. >>  They patch their Subversion clients to define a log message templat

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-14 Thread Justin Erenkrantz
On Wed, Sep 10, 2014 at 1:06 PM, Stefan Sperling wrote: > I've been working on the log-message-templates branch recently. > This branch was started by cmpilato a long time ago but for some > reason sat around untouched ever since. It's now been overhauled > by me with much help from Bert. > > I be

Re: [VOTE] merge the log-message-templates branch to trunk

2014-09-10 Thread C. Michael Pilato
On 09/10/2014 01:06 PM, Stefan Sperling wrote: > I've been working on the log-message-templates branch recently. > This branch was started by cmpilato a long time ago but for some > reason sat around untouched ever since. It's now been overhauled > by me with much help from Bert. Just for a bit of