Re: [Patch] Expression support for SVNPath and SVNParentPath

2018-11-15 Thread Branko Čibej
On 13.11.2018 17:50, Branko Čibej wrote: > On 2015/02/25 17:35:57, Graham Leggett wrote: >> Hi all, >> >> The SVNParentPath directive allows a set of repos to be placed at an > URL, but if you have more complex needs such as providing many customers > (with separately mounted home directories) acc

Re: [Patch] Expression support for SVNPath and SVNParentPath

2018-11-13 Thread Branko Čibej
On 2015/02/25 17:35:57, Graham Leggett wrote: > Hi all, > > The SVNParentPath directive allows a set of repos to be placed at an URL, but if you have more complex needs such as providing many customers (with separately mounted home directories) access to many repositories, this may not be enough.

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-03-02 Thread Graham Leggett
On 02 Mar 2015, at 1:25 PM, Branko Čibej wrote: > You may have missed my mail from a couple days ago: I did, sorry - I’m not subscribed to the list. >> I think this would be a nice feature to have in mod_dav_svn. It is, IMO, >> a better approach than the one currently implemented on the >> SVNP

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-03-02 Thread Branko Čibej
On 01.03.2015 15:23, Graham Leggett wrote: > On 27 Feb 2015, at 2:14 AM, Graham Leggett wrote: > >> By way of background, I added the regex named grouping support to httpd that >> allowed you to do stuff like [^/]+)/>, >> and I’ve been adding expression support to a growing list of httpd >> dir

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-03-01 Thread Graham Leggett
On 27 Feb 2015, at 2:14 AM, Graham Leggett wrote: > By way of background, I added the regex named grouping support to httpd that > allowed you to do stuff like [^/]+)/>, > and I’ve been adding expression support to a growing list of httpd > directives, starting with all the require directives,

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Branko Čibej
On 25.02.2015 17:35, Graham Leggett wrote: > Hi all, > > The SVNParentPath directive allows a set of repos to be placed at an URL, but > if you have more complex needs such as providing many customers (with > separately mounted home directories) access to many repositories, this may > not be eno

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Graham Leggett
On 26 Feb 2015, at 10:18 PM, Mark Phippard wrote: > Just a note to those reviewing this patch. C-Mike did something "similar" on > a branch here: > > http://svn.apache.org/repos/asf/subversion/branches/SVNParentPathTemplate/ >

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Mark Phippard
Just a note to those reviewing this patch. C-Mike did something "similar" on a branch here: http://svn.apache.org/repos/asf/subversion/branches/SVNParentPathTemplate/ I notice there is no branch.readme but the commit messages probably explain the behavior and there was thread on it here: http:/

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Philip Martin
"Bert Huijben" writes: >> >> +if (expr_err) { > > Did you see the '{' ^^^ here? > >> >> + apr_pstrcat(cmd->temp_pool, >> >> + "Cannot parse expression in SVNPath: ", >> >> + expr_err, NULL); >> > >> > expr_err contains the error message if parsing fails

RE: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: donderdag 26 februari 2015 20:13 > To: Bert Huijben > Cc: Graham Leggett; 'Subversion Development' > Subject: Re: [Patch] Expression support for SVNPath and SVNParentPa

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Philip Martin
Bert Huijben writes: > The ‘}’ is matched by that at the end of the if lines in both > blocks. (Not really our common code style) The problem is that there is a '{' before the #if and a '}' inside the #if but no '}' in the #else. I think #if code compiles and the #else code fails. >> + if (ar

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Bert Huijben
The ‘}’ is matched by that at the end of the if lines in both blocks. (Not really our common code style) Bert Sent from Windows Mail From: Philip Martin Sent: ‎Thursday‎, ‎February‎ ‎26‎, ‎2015 ‎7‎:‎13‎ ‎PM To: Graham Leggett Cc: 'Subversion Development' Graham Leggett writes:

Re: [Patch] Expression support for SVNPath and SVNParentPath

2015-02-26 Thread Philip Martin
Graham Leggett writes: > + if (arg2) { > +#if AP_MODULE_MAGIC_AT_LEAST(20111025,3) > +const char *expr_err = NULL; > + > +conf->fs_path->expr = ap_expr_parse_cmd(cmd, arg2, > AP_EXPR_FLAG_STRING_RESULT, > +&expr_err, NULL); > +if (expr_err) { > + apr_pstrcat(cmd->te