Re: [PATCH v3] Reject checkouts to existing directory

2016-11-21 Thread Daniel Shahaf
Patrick Steinhardt wrote on Mon, Nov 21, 2016 at 11:57:01 +0100: > On Sat, Nov 19, 2016 at 05:53:26AM +, Daniel Shahaf wrote: > > Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > > > + if (kind != svn_node_dir) > > > +return svn_error_createf( > > > +SVN_ERR_ILLEG

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-21 Thread Patrick Steinhardt
On Sat, Nov 19, 2016 at 05:53:26AM +, Daniel Shahaf wrote: > Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > > +++ b/subversion/svn/checkout-cmd.c > > @@ -61,6 +61,144 @@ > >Is this the same as CVS? Does it matter if it is not? > > */ > > > > +static svn_error_t * > >

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-18 Thread Daniel Shahaf
Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > +++ b/subversion/svn/checkout-cmd.c > @@ -61,6 +61,144 @@ >Is this the same as CVS? Does it matter if it is not? > */ > > +static svn_error_t * > +listing_cb(void *baton, > + const char *path, > + const s

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-16 Thread Julian Foad
Patrick Steinhardt wrote: short ping. Anybody got time to review this? As somebody "watching from the sidelines" a.k.a. "lurking", I just want to say thank you for developing this enhancement, and for driving it by giving a gentle ping like this when needed. I particularly appreciate how you

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-16 Thread Patrick Steinhardt
Hi, short ping. Anybody got time to review this? Regards Patrick On Wed, Nov 09, 2016 at 12:54:08PM +0100, Patrick Steinhardt wrote: > Hi, > > this is version three of my patch regarding checkouts to existing > directories. Thanks for the feedback on the previous two patches. > > This patch re

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-11 Thread Patrick Steinhardt
On Wed, Nov 09, 2016 at 05:09:17PM +, Daniel Shahaf wrote: > Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > > [[[ > > checkout_cmd: refuse obstructed checkouts > > The first paragraph of the log message should be a complete sentence. > (Capitalize when appropriate, use a fu

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-09 Thread Daniel Shahaf
Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > [[[ > checkout_cmd: refuse obstructed checkouts The first paragraph of the log message should be a complete sentence. (Capitalize when appropriate, use a fullstop, and there's no length limit.) Nitpick: 'checkout_cmd' isn't a thin