Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

2020-09-02 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 02 Sep 2020 11:09 -0400: > Thomas's suggestion to wrap it in an AC_CACHE_CHECK() sounds like an > approach that should fix cross-compilation for buildroot and address > Daniel's point when cross-compiling for a Mach-O target. Agreed. If a cache variable is considered

Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

2020-09-02 Thread Nathan Hartman
On Tue, Sep 1, 2020 at 10:01 PM Daniel Shahaf wrote: > > Fabrice Fontaine wrote on Mon, 31 Aug 2020 15:34 +0200: > > Le lun. 31 août 2020 à 04:40, Daniel Shahaf a > > écrit : > > > Fabrice Fontaine wrote on Sun, 30 Aug 2020 17:24 +0200: > > > > +++ b/build/ac-macros/macosx.m4 > > > > @@ -38,7 +3

Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

2020-09-02 Thread Thomas Petazzoni
Hello, On Wed, 2 Sep 2020 02:01:11 + Daniel Shahaf wrote: > I suspect this wouldn't be correct, since if it were correct, whoever > wrote the existing AC_RUN_IFELSE() call would have used > AC_COMPILE_IFELSE() instead. > > I assumed we'd need to add a way for cross-builds to explicitly set

Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

2020-09-01 Thread Daniel Shahaf
Fabrice Fontaine wrote on Mon, 31 Aug 2020 15:34 +0200: > Le lun. 31 août 2020 à 04:40, Daniel Shahaf a écrit > : > > Fabrice Fontaine wrote on Sun, 30 Aug 2020 17:24 +0200: > > > +++ b/build/ac-macros/macosx.m4 > > > @@ -38,7 +38,7 @@ AC_DEFUN(SVN_LIB_MACHO_ITERATE, > > > AC_MSG_RESULT([y

Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

2020-08-31 Thread Fabrice Fontaine
Le lun. 31 août 2020 à 04:40, Daniel Shahaf a écrit : > > Fabrice Fontaine wrote on Sun, 30 Aug 2020 17:24 +0200: > > The SVN_LIB_MACHO_ITERATE macro contains an AC_RUN_IFELSE test that > > doesn't work when cross-compiling. > > Don't say "doesn't work"; describe the symptoms, error messages, etc.

Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

2020-08-30 Thread Daniel Shahaf
Fabrice Fontaine wrote on Sun, 30 Aug 2020 17:24 +0200: > The SVN_LIB_MACHO_ITERATE macro contains an AC_RUN_IFELSE test that > doesn't work when cross-compiling. Don't say "doesn't work"; describe the symptoms, error messages, etc.. > Signed-off-by: Thomas Petazzoni > [Retrieved (and slightly u