On Sat, Apr 6, 2013 at 5:01 AM, Gabriela Gibson
wrote:
> On 4/2/13, Daniel Shahaf wrote:
>> This change will actually change the output if you resize the terminal
>> window while running tests interactively (at least in terminal emulators
>> that support the ioctl_GWINSZ approach).
>
> Oops, I ha
Gabriela Gibson wrote on Sat, Apr 06, 2013 at 13:01:52 +0100:
> On 4/2/13, Daniel Shahaf wrote:
>> I'm not sure how to interpret a return value of (0,0) that's not
>> accompanied by an error flag (C errno!=0, or a Python exception). Is
>> that normal behaviour, a bug we should be working around i
On 4/2/13, Daniel Shahaf wrote:
I'm not sure how to interpret a return value of (0,0) that's not
accompanied by an error flag (C errno!=0, or a Python exception). Is
that normal behaviour, a bug we should be working around in our code, or
an indication of a bug in our logic in the preceding lin
Gabriela Gibson wrote on Mon, Apr 01, 2013 at 22:36:57 +0100:
> [[[
>
> Disable ANSI color for dumb terminals, fix logic bug where
> dimensions of (0,0) was treated as a positive result,
> re-factored _run_tests to remove repeated calculation of
> line_length.
>
> * build/run_tests.py
> (_get_ter
On 01/04/13 01:31, Daniel Shahaf wrote:
I reworked hunk 2 because I found a bug.
The actual problem I saw was caused because the script didn't handle the
case where the terminal dimension returns as (0,0). I've fixed
this in the new patch, and cleaned up inefficient code.
> I did note, though
Gabriela Gibson wrote on Sun, Mar 31, 2013 at 23:27:48 +0100:
> [[[
> Disable ANSI color for dumb terminals, format terminal test output.
>
> * build/run_tests.py
> (TestHarness): Add test condition, format terminal output.
>
> ]]]
>
> I disabled color conditionally for dumb terminals because the
6 matches
Mail list logo
