Re: [PATCH] perform keywords substitution in mod_dav_svn

2013-04-09 Thread C. Michael Pilato
On 04/09/2013 09:46 AM, C. Michael Pilato wrote: > On 04/07/2013 01:38 PM, jinfroster wrote: >> + keyword_subst = apr_table_get(pairs, "kw"); >> + if (keyword_subst && *keyword_subst != '0') >> +comb->priv.keyword_subst = TRUE; >> + >>return NULL; >> } > > I'm with Daniel -- this should

Re: [PATCH] perform keywords substitution in mod_dav_svn

2013-04-09 Thread C. Michael Pilato
On 04/07/2013 01:38 PM, jinfroster wrote: > Index: subversion/mod_dav_svn/dav_svn.h > === > --- subversion/mod_dav_svn/dav_svn.h (revision 1465320) > +++ subversion/mod_dav_svn/dav_svn.h (working copy) > @@ -289,6 +289,9 @@ > >

Re: [PATCH] perform keywords substitution in mod_dav_svn

2013-04-07 Thread Daniel Shahaf
jinfroster wrote on Sun, Apr 07, 2013 at 21:38:07 +0400: > Hello, dev! > Here is my second attempt: > > [[[ > Accept "kw" parameter in query string. Treat any value except "0" as a > request to perform server-side keywords substitution in file contents. I would suggest requiring "1" as the value,