Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-05-04 Thread Daniel Shahaf
Ben Reser wrote on Fri, May 03, 2013 at 22:41:37 -0700: > On Fri, May 3, 2013 at 10:05 PM, Daniel Shahaf wrote: > > The same warning applies equally well to configure.ac and really to any > > sh code we write for users to run. I could see it lifted into the > > coding style guidelines part of HAC

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-05-03 Thread Ben Reser
On Fri, May 3, 2013 at 10:05 PM, Daniel Shahaf wrote: > The same warning applies equally well to configure.ac and really to any > sh code we write for users to run. I could see it lifted into the > coding style guidelines part of HACKING, for example. Noted and adding to my todo list.

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-05-03 Thread Daniel Shahaf
Ben Reser wrote on Fri, May 03, 2013 at 13:00:10 -0700: > On Wed, May 1, 2013 at 8:07 AM, Gabriela Gibson > wrote: > > Should this note be a comment in get-deps.sh? > > Done in r1478951. The same warning applies equally well to configure.ac and really to any sh code we write for users to run. I

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-05-03 Thread Ben Reser
On Wed, May 1, 2013 at 8:07 AM, Gabriela Gibson wrote: > Should this note be a comment in get-deps.sh? Done in r1478951.

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-05-01 Thread Gabriela Gibson
On 30/04/13 18:27, Ben Reser wrote: 1) Need to avoid using GNU tar options on this. Just like we don't use the j option to tar to deal with bzip2 we can't use the z option to deal with gzip. Should this note be a comment in get-deps.sh?

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Johan Corveleyn
On Tue, Apr 30, 2013 at 9:26 PM, Daniel Shahaf wrote: > FWIW, I did find two references: > >> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3 > > No opinion as I don't build on windows any more, but CCing jcorvel. > (Johan: the question is whether we want to update the zlib version used > by window

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 12:38 PM, Daniel Shahaf wrote: > I figured we'd either release 1.6.22 without a -deps tarball, or > resurrect the script from svn history. We could indeed do that, it's come up before.

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Daniel Shahaf
Ben Reser wrote on Tue, Apr 30, 2013 at 12:36:03 -0700: > On Tue, Apr 30, 2013 at 12:26 PM, Daniel Shahaf wrote: > >> tools/dist/make-deps-tarball.sh:ZLIB=zlib-1.2.7 > > > > Script only used for 1.6 and earlier; we can probably remove the script > > from HEAD. > > Yes, but it needs to stay until

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 12:26 PM, Daniel Shahaf wrote: > FWIW, I did find two references: Ahh I did miss these. >> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3 > > No opinion as I don't build on windows any more, but CCing jcorvel. > (Johan: the question is whether we want to update the zlib v

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Daniel Shahaf
Ben Reser wrote on Tue, Apr 30, 2013 at 12:03:29 -0700: > On Tue, Apr 30, 2013 at 10:52 AM, Daniel Shahaf wrote: > > 4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever > > else we mention what the recommended zlib version is > > Not sure where that's from, but we don't recommend a v

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 10:52 AM, Daniel Shahaf wrote: > 4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever > else we mention what the recommended zlib version is Not sure where that's from, but we don't recommend a version of zlib. The closest we come to that is the Windows docs sa

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Daniel Shahaf
Ben Reser wrote on Tue, Apr 30, 2013 at 10:27:18 -0700: > On Tue, Apr 30, 2013 at 8:07 AM, Gabriela Gibson > wrote: > > [[[ > > > > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz > > > > * subversion/build/get-deps.sh: > > (): Update zlib version number. > > (get_zlib):

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 10:11 AM, Branko Čibej wrote: > +1, and I think this should go into 1.8 as well as trunk. It will, part of our release process is to check that get-deps.sh works now, and given that the zlib folks remove the link we use with every version, we would have found this then.

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 8:07 AM, Gabriela Gibson wrote: > [[[ > > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz > > * subversion/build/get-deps.sh: > (): Update zlib version number. > (get_zlib): Modify tar command and file extension. > > ]]] Applied in r1477730 with s

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Branko Čibej
On 30.04.2013 17:07, Gabriela Gibson wrote: > [[[ > > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz > > * subversion/build/get-deps.sh: > (): Update zlib version number. > (get_zlib): Modify tar command and file extension. > > ]]] +1, and I think this should go into 1.8