Re: [PATCH] fix repos-to-wc copy dst parents creation

On 14.10.2018 21:39, Nikita Slyusarev wrote: > 14.10.2018, 17:17, "Branko Čibej" : > > > > Hey. Thanks for the nudge. > > > > I have just one comment: The two new test scenarios you should be split > > into their own test cases. Not only is it bad practice to make a test > > case test more than one

Re: [PATCH] fix repos-to-wc copy dst parents creation

 14.10.2018, 17:17, "Branko Čibej" :Hey. Thanks for the nudge.I have just one comment: The two new test scenarios you should be splitinto their own test cases. Not only is it bad practice to make a testcase test more than one scenario, it also defeats parallel test execution.Fixed version (the patc

Re: [PATCH] fix repos-to-wc copy dst parents creation

 14.10.2018, 17:17, "Branko Čibej" :Hey. Thanks for the nudge.I have just one comment: The two new test scenarios you should be splitinto their own test cases. Not only is it bad practice to make a testcase test more than one scenario, it also defeats parallel test execution.Ok, sure. -- Nikita Sly

Re: [PATCH] fix repos-to-wc copy dst parents creation

On 14.10.2018 15:48, Nikita Slyusarev wrote: >   > 04.08.2018, 17:47, "Nikita Slyusarev" : >> >> For everyone's sanity I'd better not only bump the thread, but also >> resend the patch and the log message I had prepared back then. >> >> 14.07.2018, 19:04, "Nikita Slyusarev" >

Re: [PATCH] fix repos-to-wc copy dst parents creation

 04.08.2018, 17:47, "Nikita Slyusarev" :For everyone's sanity I'd better not only bump the thread, but also resend the patch and the log message I had prepared back then.14.07.2018, 19:04, "Nikita Slyusarev" : [[[Correctly handle existing parent directories when performing re

Re: [PATCH] fix repos-to-wc copy dst parents creation

> Nikita Slyusarev wrote on 04 Aug 2018: > > For everyone's sanity I'd better not only bump the thread, but also > > resend the patch and the log message I had prepared back then. Daniel Shahaf wrote: > Filed SVN-4768. If anyone could review the patch, that'd be great; Thank you Nikita for cont

Re: [PATCH] fix repos-to-wc copy dst parents creation

Nikita Slyusarev wrote on Sat, 04 Aug 2018 17:47 +0300: > For everyone's sanity I'd better not only bump the thread, but also > resend the patch and the log message I had prepared back then. > Filed SVN-4768. If anyone could review the patch, that'd be great; it's a one-liner fix with a test...

Re: [PATCH] fix repos-to-wc copy dst parents creation

For everyone's sanity I'd better not only bump the thread, but also resend the patch and the log message I had prepared back then. 14.07.2018, 19:04, "Nikita Slyusarev" : > 14.07.2018, 17:18, "Daniel Shahaf" : >>  It would help to add a regression test to subversion/tests/cmdline/ or >>  subversi

Re: [PATCH] fix repos-to-wc copy dst parents creation

Bump? 20.07.2018, 11:04, "Nikita Slyusarev" : > 14.07.2018, 20:05, "Daniel Shahaf" : >>  The submission includes a log message and an explanation of the problem. In >>  that regard it is complete and ready for review. That will hopefully happen >> on >>  Monday. Should you not get a response, do

Re: [PATCH] fix repos-to-wc copy dst parents creation

14.07.2018, 20:05, "Daniel Shahaf" : > The submission includes a log message and an explanation of the problem. In > that regard it is complete and ready for review. That will hopefully happen on > Monday. Should you not get a response, do prod us again. Hello. Any news with the review process?

Re: [PATCH] fix repos-to-wc copy dst parents creation

14.07.2018, 17:18, "Daniel Shahaf" : > It would help to add a regression test to subversion/tests/cmdline/ or > subversion/tests/libsvn_client/. Thanks for your advice. I've added cmdline tests to the patch and fixed the log message accordingly. [[[ Correctly handle existing parent directories wh

Re: [PATCH] fix repos-to-wc copy dst parents creation

Nikita Slyusarev wrote on Sat, Jul 14, 2018 at 13:19:54 +0300: > Hello. This patch fixes svn copy behaviour. Let's discuss. > What are my next steps here? Can I help somehow with patch acceptance? The submission includes a log message and an explanation of the problem. In that regard it is comple

Re: [PATCH] fix repos-to-wc copy dst parents creation

Hello. This patch fixes svn copy behaviour. Let's discuss. What are my next steps here? Can I help somehow with patch acceptance? 12.07.2018, 01:19, "Nikita Slyusarev" : > [[[ > Correctly handle existing parent directories when performing repos-to-wc copy. > > * subversion/libsvn_client/copy.c >