Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-04 Thread Joe Orton
On Thu, May 03, 2018 at 08:32:56PM +0100, Philip Martin wrote: > Your patch is an improvement so I would be happy to see it on > trunk/1.10. Going further and removing some .pc files is probably also > suitable for 1.10. Changing the DSO names and installation location is > probably not suitable

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Philip Martin
Joe Orton writes: > I thought about that, but the SVN buildsystem is building & installing > them like libraries not like DSOs (which should be linked with libtool's > -module argument and not installed directly in $libdir), I suspect that is accidental. The RA/FS option --enable-dso, which b

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Joe Orton
On Wed, May 02, 2018 at 04:32:26PM +0100, Philip Martin wrote: > Philip Martin writes: > > >> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and > >> make dependencies private. > > > > Looks OK to me. > > Perhaps we should delete the .pc files for gnome/kwallet auth libraries

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Stefan Sperling
On Thu, May 03, 2018 at 09:11:33AM +0100, Philip Martin wrote: > Philip Martin writes: > > > Philip Martin writes: > > > >>> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and > >>> make dependencies private. > >> > >> Looks OK to me. > > > > Perhaps we should delete the .pc

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >>> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and >>> make dependencies private. >> >> Looks OK to me. > > Perhaps we should delete the .pc files for gnome/kwallet auth libraries. > The corresponding libraries do not really

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-02 Thread Philip Martin
Philip Martin writes: >> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and >> make dependencies private. > > Looks OK to me. Perhaps we should delete the .pc files for gnome/kwallet auth libraries. The corresponding libraries do not really have a public API and I think nodod

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-01 Thread Philip Martin
Joe Orton writes: > libsvn_auth_gnome_keyring.pc is wrong in 1.10.0; when built against > libsecret it still references the gnome-keyring library. > > ... > Requires: apr-1 gnome-keyring-1 > Requires.private: libsvn_subr > > The dep should also be private; fix attached OK? > > [[[ > Fixes libs