Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-20 Thread Julian Foad
Dmitry Pavlenko wrote: > Here's a failing test for "no dot" case. After removing the code as I wrote > before the test passes. Thank you. Committed in r1836339. I also made a 'round-trip' version of the test and committed that in r1836340. - Julian

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-19 Thread Dmitry Pavlenko
Hello Julian, Here's a failing test for "no dot" case. After removing the code as I wrote before the test passes. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge > Dmitry Pavlenko wrote: > > > ... would you mind making a regression test? ... > > > > OK, I could do that,

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-12 Thread Julian Foad
Dmitry Pavlenko wrote: > > ... would you mind making a regression test? ... > OK, I could do that, but much later, in 2 weeks maybe... Thanks. I think we should commit your fix anyway, but better if we can also fix the 'svn diff' output and also add a test or two. I am thinking two tests would m

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-09 Thread Dmitry Pavlenko
Hello Julian, OK, I could do that, but much later, in 2 weeks maybe. Now I'm busy testing patch functionality for other cases. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge > Dmitry, the other thing is, would you mind making a regression test for this > issue? That woul

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-09 Thread Julian Foad
Dmitry, the other thing is, would you mind making a regression test for this issue? That would be really good to have. - Julian Julian Foad wrote on 2018-07-09: > Dmitry Pavlenko wrote on 2018-07-09: > > Note that the patch looks like > > > > Index: /tmp/wc > >

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-09 Thread Julian Foad
Dmitry Pavlenko wrote on 2018-07-09: > Note that the patch looks like > > Index: /tmp/wc > === > diff --git a/ b/ > --- a/ (revision 0) > +++ b/ (working copy) > > Property changes on: > [...] Thanks for the bug report. I like re