Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-10-23 Thread Daniel Trebbien
On Mon, Oct 18, 2010 at 3:05 AM, Gavin Beau Baumanis wrote: > Hi Daniel, > > This is just a friendly poke. > Are you happy to have me "annoy" you every so often - or would just like me > leave it entirely with you ? > > > Gavin "Beau" Baumanis Hi Gavin, I don't mind at all. Regarding this svnsy

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-10-18 Thread Gavin Beau Baumanis
Hi Daniel, This is just a friendly poke. Are you happy to have me "annoy" you every so often - or would just like me leave it entirely with you ? Gavin "Beau" Baumanis On 29/09/2010, at 11:14 AM, Daniel Trebbien wrote: > Hi Gavin, > > There have been some things that I have needed to do rec

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-28 Thread Gavin Beau Baumanis
Daniel, Absolutely no apology required. Just about everyone here is a volunteer of the own spare time. I was checking for my own purposes, in case I had missed an alternate message thread. Gavin "Beau" Baumanis On 29/09/2010, at 11:14 AM, Daniel Trebbien wrote: > Hi Gavin, > > There have be

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-28 Thread Daniel Trebbien
Hi Gavin, There have been some things that I have needed to do recently, so I haven't been working on the patches as much as I would like. But, I am still interested in finishing them. My apologies for the delay... Daniel On Tue, Sep 28, 2010 at 6:07 PM, Gavin Beau Baumanis wrote: > Hi Danie

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-28 Thread Gavin Beau Baumanis
Hi Daniel (Trebbien), Just thought I would ask for an update, please. I still have you on my "watch - list" - so there is no rush - just making sure for my own sanity that I haven't missed an email / thread about your patch submission. Gavin "Beau" Baumanis On 22/09/2010, at 2:56 AM, Daniel

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Shahaf
Daniel Trebbien wrote on Tue, Sep 21, 2010 at 08:12:38 -0700: > On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf > wrote: > > Need the word "to" after the semicolon for the English to be correct. > > Fixed. (When I say "fixed", I mean that I committed a fix in my own > fork of Subversion: http:/

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Trebbien
Daniel Trebbien gmail.com> writes: > Yes, I did copy-and-paste. I see your point, though, and I am going to > correct this by adding another `static` function that both will call. Never mind the talk of a new static function. `svn_subst_translate_string` should of course call `svn_subst_translat

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Trebbien
Daniel Shahaf daniel.shahaf.name> writes: > > Gavin, thanks for the information, but I think Daniel Trebbien already > knows this. > > Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000: > > Hi Daniel, > > > > You should always feel comfortable with "pimping" your own patch > >

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Trebbien
On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf wrote: >> * subversion/include/svn_subst.h >>   Added documentation of the new public API function >>   svn_subst_translate_string2(). >> > > Should use this syntax: > > * subversion/include/svn_subst.h >  (svn_subst_translate_string2): New function.

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Daniel Shahaf
(to stsp and other interested parties: I reviewed only the libsvn_subr part of the patch; see last paragraph for details) Daniel Trebbien wrote on Mon, Sep 13, 2010 at 19:22:38 -0700: > Attached are the new patch and log message. > > I have already shared one test repository with this mailing lis

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Stefan Sperling
On Sun, Sep 19, 2010 at 11:14:02AM +0100, Daniel Shahaf wrote: > Thanks for the reminder. I've been at Hursley this weekend (and haven't > had much time for coding!), but it's on my list. Same here (at Hursely and interested in the patch). Feel free to prod me about it if you don't hear from anyo

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Daniel Shahaf
Gavin, thanks for the information, but I think Daniel Trebbien already knows this. :-) Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000: > Hi Daniel, > > You should always feel comfortable with "pimping" your own patch submissions. > What you have done is completely fine. > > But

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Daniel Shahaf
Thanks for the reminder. I've been at Hursley this weekend (and haven't had much time for coding!), but it's on my list. Daniel Trebbien wrote on Sat, Sep 18, 2010 at 21:33:07 +: > It has been a few days since I submitted my revised patch > (http://thread.gmane.org/gmane.comp.version-control.

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-18 Thread Gavin Beau Baumanis
Hi Daniel, You should always feel comfortable with "pimping" your own patch submissions. What you have done is completely fine. But just in case you don't know - the Subversion project does have a Patch Manager. The role of the Patch Manager is to ensure that patch submissions (mostly) by peopl

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-18 Thread Daniel Trebbien
It has been a few days since I submitted my revised patch (http://thread.gmane.org/gmane.comp.version-control.subversion.devel/122550), and I just want to make sure that it hasn't been forgotten. I am waiting for the changes to be committed before I work on related enhancements.