Thanks Hyrum,
Appreciate the update.
I'll remove it from my "watch" list.
On 28/03/2011, at 11:58 PM, Hyrum K Wright wrote:
> Actually, it did. Mike committed it in r1084335, and reported that
> fact in this thread on Mar 22.
>
> Best,
> -Hyrum
>
> On Sun, Mar 27, 2011 at 7:27 PM, Gavin Baum
Actually, it did. Mike committed it in r1084335, and reported that
fact in this thread on Mar 22.
Best,
-Hyrum
On Sun, Mar 27, 2011 at 7:27 PM, Gavin Baumanis wrote:
> Ping.
> This patch submission has received no comments.
>
>
>
> On 22/03/2011, at 8:27 AM, Danny Trebbien wrote:
>
>> On Mon, M
Ping.
This patch submission has received no comments.
On 22/03/2011, at 8:27 AM, Danny Trebbien wrote:
> On Mon, Mar 21, 2011 at 10:20 AM, Philip Martin
> wrote:
>> Danny Trebbien writes:
>>> Attached are the patch, the log message, and the two TGZ archives of
>>> DUMP files (for the tests).
On 03/22/2011 08:41 PM, Danny Trebbien wrote:
>> Finished committing this in r1084335, though pieces of it were committed in
>> prior revisions as they weren't strictly part of this logical change.
>>
>> --
>> C. Michael Pilato
>> CollabNet <> www.collab.net <> Distributed Development On D
> Finished committing this in r1084335, though pieces of it were committed in
> prior revisions as they weren't strictly part of this logical change.
>
> --
> C. Michael Pilato
> CollabNet <> www.collab.net <> Distributed Development On Demand
Thank you so much!!
Issue 3817 (http://subv
On 03/22/2011 02:24 PM, C. Michael Pilato wrote:
> On 03/21/2011 05:27 PM, Danny Trebbien wrote:
>> On Mon, Mar 21, 2011 at 10:20 AM, Philip Martin
>> wrote:
>>> Danny Trebbien writes:
Attached are the patch, the log message, and the two TGZ archives of
DUMP files (for the tests).
>>>
>
On 03/21/2011 05:27 PM, Danny Trebbien wrote:
> On Mon, Mar 21, 2011 at 10:20 AM, Philip Martin
> wrote:
>> Danny Trebbien writes:
>>> Attached are the patch, the log message, and the two TGZ archives of
>>> DUMP files (for the tests).
>>
>> The patch is missing.
>>
>> --
>> Philip
>
> Sorry. A
On Mon, Mar 21, 2011 at 10:20 AM, Philip Martin
wrote:
> Danny Trebbien writes:
>> Attached are the patch, the log message, and the two TGZ archives of
>> DUMP files (for the tests).
>
> The patch is missing.
>
> --
> Philip
Sorry. Attached is the patch with a .txt extension.
Index: subversion/
Danny Trebbien writes:
> Attached are the patch, the log message, and the two TGZ archives of
> DUMP files (for the tests).
The patch is missing.
--
Philip
I know that everyone is incredibly busy preparing 1.7, but would
someone please review and commit this patch? I don't want to see it
slip to 1.8.
Attached are the patch, the log message, and the two TGZ archives of
DUMP files (for the tests). They are the same as before, except that
I diff'ed ag
Hi Everyone,
I have logged this submission in the issue tracker.
#3817 refers.
http://subversion.tigris.org/issues/show_bug.cgi?id=3817
On 21/02/2011, at 3:31 AM, Danny Trebbien wrote:
> On Mon, Feb 14, 2011 at 12:38 AM, Daniel Shahaf
> wrote:
>> Danny Trebbien wrote on Sun, Feb 13, 2011 at
On Mon, Feb 14, 2011 at 12:38 AM, Daniel Shahaf wrote:
> Danny Trebbien wrote on Sun, Feb 13, 2011 at 20:20:45 -0800:
>> Attached are the corrected patch and log message. The new patch
>> incorporates this fix:
>> https://github.com/dtrebbien/subversion/commit/190f876b52626be6b30fe4e5a311c113fd87e
Danny Trebbien wrote on Sun, Feb 13, 2011 at 20:20:45 -0800:
> Attached are the corrected patch and log message. The new patch
> incorporates this fix:
> https://github.com/dtrebbien/subversion/commit/190f876b52626be6b30fe4e5a311c113fd87e589
Is there a github link that shows the equivalent of 'svn
Danny Trebbien wrote on Sat, Feb 12, 2011 at 18:17:30 -0800:
> +def identity_copy(sbox):
> + "copy UTF-8 svn:* props identically"
> + orig_lc_all = locale.setlocale(locale.LC_ALL)
> + other_locales = [ "English.1252", "German.1252", "French.1252",
> "en_US.ISO-8859-1", "en_GB.ISO-8859-1", "de_D
Ping. This patch submission is yet to receive any new comments.
On 26/01/2011, at 3:29 AM, Danny Trebbien wrote:
>> Hi Danny.
>>
>> I committed the patch you refer to, on which this one depends, in
>> r1063320. However, I'm not likely to get around to reviewing this patch
>> any time soon. It
> Hi Danny.
>
> I committed the patch you refer to, on which this one depends, in
> r1063320. However, I'm not likely to get around to reviewing this patch
> any time soon. It would be great if someone else could take it.
>
> - Julian
Okay. That's fine. Thank you for the update.
On Fri, 2011-01-14, Danny Trebbien wrote:
> Attached are version 4 of the patch and log message. Also attached are
> two TGZ archives containing the six DUMP files that the new svnsync
> and svnrdump tests depend upon. These TGZ archives can be extracted
> directly into your working copy of trunk.
Ping. I haven't yet received feedback on this patch.
On Fri, Jan 14, 2011 at 1:01 PM, Danny Trebbien wrote:
> Attached are version 4 of the patch and log message. Also attached are
> two TGZ archives containing the six DUMP files that the new svnsync
> and svnrdump tests depend upon. These TGZ ar
On Fri, 2011-01-14 at 09:16 -0800, Danny Trebbien wrote:
> >>> - SVN_ERR(normalize_string(&value, &was_normalized, pool));
> >>> + SVN_ERR(normalize_string(&value, &was_normalized,
> >>> eb->prop_encoding,
> >>> + pool, pool));
> >>>if (was_normalize
>>> - SVN_ERR(normalize_string(&value, &was_normalized, pool));
>>> + SVN_ERR(normalize_string(&value, &was_normalized, eb->prop_encoding,
>>> + pool, pool));
>>> if (was_normalized)
>>> - (*(eb->normalized_node_props_counter))++;
>>> + (
Danny Trebbien wrote on Mon, Jan 10, 2011 at 08:55:35 -0800:
> >> Perhaps, though, I should use svn_subst_translate_string2() with the
> >> encoding set to "UTF-8". It would greatly simplify normalize_string(),
> >
> > +1. Just call it with encoding=NULL; using the same API in both
> > branches ma
>> Perhaps, though, I should use svn_subst_translate_string2() with the
>> encoding set to "UTF-8". It would greatly simplify normalize_string(),
>
> +1. Just call it with encoding=NULL; using the same API in both
> branches makes life easier for the next person to revv that API.
One thing that w
Danny Trebbien wrote on Fri, Jan 07, 2011 at 13:03:18 -0800:
> > Refresh my memory please: did we decide in some thread that the
> > recodings should be counted too?
>
> At one point Stefan asked me if I was interested:
> http://article.gmane.org/gmane.comp.version-control.subversion.devel/122540
> Seems to me it would be good for the name of the command-line option to
> include "property", e.g. "--prop-source-encoding". I note that this
> option is not intended to be used frequently so I don't imagine it's a
> problem to have a long name.
How about "--source-prop-encoding"?
>> > Index:
Hi Daniel and Julian,
My apologies for the delay in responding.
> Refresh my memory please: did we decide in some thread that the
> recodings should be counted too?
At one point Stefan asked me if I was interested:
http://article.gmane.org/gmane.comp.version-control.subversion.devel/122540
>>
On Sun, 2011-01-02, Daniel Shahaf wrote:
> Danny Trebbien wrote on Sun, Dec 26, 2010 at 15:39:05 -0800:
> > Attached are version 3 of the patch and corresponding log message.
> > Also attached is a TGZ archive of two Subversion repository dumps that
> > are used by a new test case.
> > [[[
> > Add
[ trimming CC ]
Danny Trebbien wrote on Sun, Dec 26, 2010 at 15:39:05 -0800:
> Attached are version 3 of the patch and corresponding log message.
> Also attached is a TGZ archive of two Subversion repository dumps that
> are used by a new test case.
> [[[
> Add a command line option (--source-enc
Attached are version 3 of the patch and corresponding log message.
Also attached is a TGZ archive of two Subversion repository dumps that
are used by a new test case.
Index: subversion/svnsync/sync.h
===
--- subversion/svnsync/sync.h
On Mon, Oct 18, 2010 at 3:05 AM, Gavin Beau Baumanis
wrote:
> Hi Daniel,
>
> This is just a friendly poke.
> Are you happy to have me "annoy" you every so often - or would just like me
> leave it entirely with you ?
>
>
> Gavin "Beau" Baumanis
Hi Gavin,
I don't mind at all. Regarding this svnsy
Hi Daniel,
This is just a friendly poke.
Are you happy to have me "annoy" you every so often - or would just like me
leave it entirely with you ?
Gavin "Beau" Baumanis
On 29/09/2010, at 11:14 AM, Daniel Trebbien wrote:
> Hi Gavin,
>
> There have been some things that I have needed to do rec
Daniel,
Absolutely no apology required.
Just about everyone here is a volunteer of the own spare time.
I was checking for my own purposes, in case I had missed an alternate message
thread.
Gavin "Beau" Baumanis
On 29/09/2010, at 11:14 AM, Daniel Trebbien wrote:
> Hi Gavin,
>
> There have be
Hi Gavin,
There have been some things that I have needed to do recently, so I
haven't been working on the patches as much as I would like. But, I
am still interested in finishing them.
My apologies for the delay...
Daniel
On Tue, Sep 28, 2010 at 6:07 PM, Gavin Beau Baumanis
wrote:
> Hi Danie
Hi Daniel (Trebbien),
Just thought I would ask for an update, please.
I still have you on my "watch - list" - so there is no rush - just making sure
for my own sanity that I haven't missed an email / thread about your patch
submission.
Gavin "Beau" Baumanis
On 22/09/2010, at 2:56 AM, Daniel
Daniel Trebbien wrote on Tue, Sep 21, 2010 at 08:12:38 -0700:
> On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf
> wrote:
> > Need the word "to" after the semicolon for the English to be correct.
>
> Fixed. (When I say "fixed", I mean that I committed a fix in my own
> fork of Subversion: http:/
Daniel Trebbien gmail.com> writes:
> Yes, I did copy-and-paste. I see your point, though, and I am going to
> correct this by adding another `static` function that both will call.
Never mind the talk of a new static function. `svn_subst_translate_string`
should
of course call `svn_subst_translat
Daniel Shahaf daniel.shahaf.name> writes:
>
> Gavin, thanks for the information, but I think Daniel Trebbien already
> knows this.
>
> Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000:
> > Hi Daniel,
> >
> > You should always feel comfortable with "pimping" your own patch
> >
On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf wrote:
>> * subversion/include/svn_subst.h
>> Added documentation of the new public API function
>> svn_subst_translate_string2().
>>
>
> Should use this syntax:
>
> * subversion/include/svn_subst.h
> (svn_subst_translate_string2): New function.
(to stsp and other interested parties: I reviewed only the libsvn_subr
part of the patch; see last paragraph for details)
Daniel Trebbien wrote on Mon, Sep 13, 2010 at 19:22:38 -0700:
> Attached are the new patch and log message.
>
> I have already shared one test repository with this mailing lis
On Sun, Sep 19, 2010 at 11:14:02AM +0100, Daniel Shahaf wrote:
> Thanks for the reminder. I've been at Hursley this weekend (and haven't
> had much time for coding!), but it's on my list.
Same here (at Hursely and interested in the patch).
Feel free to prod me about it if you don't hear from anyo
Gavin, thanks for the information, but I think Daniel Trebbien already
knows this. :-)
Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000:
> Hi Daniel,
>
> You should always feel comfortable with "pimping" your own patch submissions.
> What you have done is completely fine.
>
> But
Thanks for the reminder. I've been at Hursley this weekend (and haven't
had much time for coding!), but it's on my list.
Daniel Trebbien wrote on Sat, Sep 18, 2010 at 21:33:07 +:
> It has been a few days since I submitted my revised patch
> (http://thread.gmane.org/gmane.comp.version-control.
Hi Daniel,
You should always feel comfortable with "pimping" your own patch submissions.
What you have done is completely fine.
But just in case you don't know - the Subversion project does have a Patch
Manager.
The role of the Patch Manager is to ensure that patch submissions (mostly) by
peopl
It has been a few days since I submitted my revised patch
(http://thread.gmane.org/gmane.comp.version-control.subversion.devel/122550),
and I just want to make sure that it hasn't been forgotten. I am waiting for
the changes to be committed before I work on related enhancements.
Stefan Sperling wrote on Mon, Sep 13, 2010 at 12:16:44 +0200:
> Having a similar reporting feature in "svnadmin verify", and ways to
> fix these problems with "svndumpfilter" or maybe even "svnadmin recover"
> wouldn't hurt either.
The verify functionality is part of the FS layer; but the FS layer
On Sun, Sep 12, 2010 at 04:21:03PM -0700, Daniel Trebbien wrote:
> I removed the normalization counting code without much thought in my
> hastened efforts to produce a version of `svnsync` that I could use to
> mirror the GNU Nano repository. Currently, I am thinking that Stefan
> Sperling's idea o
Daniel Trebbien wrote on Sun, Sep 12, 2010 at 16:21:03 -0700:
> On Sun, Sep 12, 2010 at 1:49 PM, Daniel Shahaf
> wrote:
> > Unrelatedly, you mentioned that in the repository you work on there are
> > soem properties in latin1 and some in utf8. So one will need (until
> > they fix the properties
On Sun, Sep 12, 2010 at 1:49 PM, Daniel Shahaf wrote:
>> When I was working on my changes, I was looking for a "to UTF-8"
>> function that would return whether it actually re-encoded the input
>> string, but did not find one. The re-encoding function that I used,
>> `svn_subst_translate_string`, a
Daniel Trebbien wrote on Fri, Sep 10, 2010 at 16:57:41 -0700:
> >> * subversion/svnsync/main.c
> >> (svnsync_cmd_table): Added svnsync_opt_source_encoding to the list
> >> of acceptable options for the init, sync, and copy-revprops
> >> subcommands.
> >
> > Missing indentation on the non-first li
Daniel Shahaf writes:
>Daniel Trebbien wrote on Fri, Sep 10, 2010 at 12:24:29 -0700:
>> After applying my patch and recompiling `svnsync`, QA can test with
>> the script at: http://pastebin.com/g0n9uqYr
>
>QA? That's not how open source works :-)
>
>Daniel
>(re QA remark, I couldn't find an appr
On Fri, Sep 10, 2010 at 04:57:41PM -0700, Daniel Trebbien wrote:
> When I was working on my changes, I was looking for a "to UTF-8"
> function that would return whether it actually re-encoded the input
> string, but did not find one. The re-encoding function that I used,
> `svn_subst_translate_stri
>> * subversion/svnsync/main.c
>> (svnsync_cmd_table): Added svnsync_opt_source_encoding to the list
>> of acceptable options for the init, sync, and copy-revprops
>> subcommands.
>
> Missing indentation on the non-first lines. Should be in one of these forms:
>
> [[[
> * subversion/svnsync/main
Daniel Trebbien wrote on Fri, Sep 10, 2010 at 12:24:29 -0700:
> The test repository (attached) was created with Subversion version
> 1.6.12 (r955767) on a Debian Squeeze AMD64 system.
Since you're working on this code, let me point out that 'svnadmin load'
works at a level below the UTF-8 validati
Daniel Trebbien wrote on Fri, Sep 10, 2010 at 11:12:20 -0700:
> On Fri, Sep 10, 2010 at 9:16 AM, Daniel Shahaf
> wrote:
> > The patch didn't make it to the list (only to my personal copy), could
> > you please re-send with the patch in "text/plain" MIME type?
>
> Hmmm. I wonder if adding a .txt
Note: I was using the GNU Nano repository (svn://svn.sv.gnu.org/nano)
to test my changes, but it's not ideal because the first commit where
the --source-encoding feature is needed is revision 619. Also, as of
now, 29 of the 4518 commits have non-ASCII log messages with 21
encoded in ISO-8859-1 and
On Fri, Sep 10, 2010 at 9:16 AM, Daniel Shahaf wrote:
> The patch didn't make it to the list (only to my personal copy), could
> you please re-send with the patch in "text/plain" MIME type?
Hmmm. I wonder if adding a .txt extension will work...
Index: subversion/svnsync/sync.h
===
Daniel Trebbien writes:
> [[[
> Add a command line option to the svnsync init, sync, and copy-revprops
> subcommands (--source-encoding) that allows the user to specify the
> character encoding of translatable properties from the source
> repository. This is needed to allow svnsync to import some
The patch didn't make it to the list (only to my personal copy), could
you please re-send with the patch in "text/plain" MIME type?
Daniel Trebbien wrote on Fri, Sep 10, 2010 at 09:10:08 -0700:
> [[[
> Add a command line option to the svnsync init, sync, and copy-revprops
> subcommands (--source-e
57 matches
Mail list logo
