Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

Kannan wrote: > Julian Foad wrote: > > On Fri, 2009-12-04 at 19:49 +0200, Daniel Shahaf wrote: > >> What's the benefit of this change? > > If not in many places, the variable is used only in one such instance > which could very well be replaced with the method. Sort of minor > tweak. > > >

Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: > On Fri, 2009-12-04 at 19:49 +0200, Daniel Shahaf wrote: >> What's the benefit of this change? If not in many places, the variable is used only in one such instance which could very well be replaced with the method. Sort of min

Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

On Fri, 2009-12-04 at 19:49 +0200, Daniel Shahaf wrote: > What's the benefit of this change? Speaking for myself... it's clearly just a tiny code improvement. +1. I thin it is also more consistent with the way such checks are done in other svn_client functions. - Julian > Kannan wrote on Fri,

Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

What's the benefit of this change? Kannan wrote on Fri, 4 Dec 2009 at 23:06 +0530: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Log: > Instead of using a separate bool variable, use `svn_path_is_url()'. > > * subversion/libsvn_client/log.c > (svn_client_log5): Remove the bool variab