Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode (#4889)

2022-02-25 Thread Julian Foad
Filed as #4889, https://subversion.apache.org/issue/4889, "Pristines-on-demand: per-WC config"

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-10 Thread Karl Fogel
On 10 Feb 2022, Julian Foad wrote: Julian Foad wrote: pristines-on-demand behaviour needs to be made conditional on WC format. [...] Once that is done, I plan to return to this per-WC config option storage. Now that we have (just) decided the default WC format will be the old format (31) an

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-10 Thread Evgeny Kotkov
Julian Foad writes: > Some people said it should be in wc.db. Evgeny wrote, "this sounds like > a property associated with a specificwc_id in the database. I would say > that this pretty much rules out optionsof storing it outside the wc.db." > But (Brane wrote) "WC_ID is hardcoded to 1 pretty m

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-10 Thread Julian Foad
Julian Foad wrote: > pristines-on-demand behaviour needs to be made conditional on WC format. > [...] > Once that is done, I plan to return to this per-WC config option storage. Now that we have (just) decided the default WC format will be the old format (31) and upgrading a WC will be optional, t

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-09 Thread Julian Foad
I haven't heard any further feedback on this settings storage. I am still favouring the new in-WC config file ('wc/.svn/config'). It seems straightforward and understandable with hopefully not so much potential for bikeshedding (no need for new command line options or commands, for example). On t

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-03 Thread Julian Foad
Some more notes on pristines-mode configuration. Naming of option values: agreed that we need to choose names carefully, avoiding ambiguity like 'mode=all'. On the consensus that: (1) There should be a user config (file/registry/cmdline) option to set the desired pristines-mode that will be ap

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-03 Thread Julian Foad
Karl Fogel wrote: > Does the current design involve a new per-wc flag that indicates > something about a pristines-(present|absent) mode? > > [...] ideally we would record that fact solely on a > per-file basis. [...] That's a good question to ask, as it's a little complex. TL;DR: - There i

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-02 Thread Karl Fogel
In an ideal world, I'd have time to study the details closely enough that I would already know the answer to the question I'm about to ask. However, after (quickly) reading the posts so far, I still wasn't completely clear on the answer, so... what the heck, I'll just ask! Does the current

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-01 Thread Julian Foad
Daniel Shahaf wrote: > The value "all" [...] is not handled at all by check_pristines_mode(). > [...] > Or perhaps this patch is at too early a stage for any of this to > matter :-) That's right: all those values in the patch are just pencil sketches at this stage. The same answer applies to Joha

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-01-31 Thread Daniel Shahaf
Julian Foad wrote on Fri, Jan 28, 2022 at 17:15:53 +: > For interest/comments. Please use text/* MIME type for patches so our MUAs show them inline. Naming patches *.txt usually achieves this. > On the 'pristines-on-demand' branch: > > - Sketch of configurable pristines-mode per WC. > -