Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-06-01 Thread Morten Kloster
On Wed, Jun 1, 2011 at 10:28 AM, Johan Corveleyn wrote: > On Wed, Jun 1, 2011 at 10:04 AM, Philip Martin > wrote: >> Stefan Fuhrmann writes: >> Updated log message: [[[ Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. * subversion/libsvn_diff/lcs.c

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-06-01 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 10:04 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > >>> Updated log message: >>> [[[ >>> Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. >>> >>> * subversion/libsvn_diff/lcs.c >>>   (svn_diff__snake): Removed idx parameter (always 0) >>>   (svn_dif

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-06-01 Thread Philip Martin
Stefan Fuhrmann writes: >> Updated log message: >> [[[ >> Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. >> >> * subversion/libsvn_diff/lcs.c >> (svn_diff__snake): Removed idx parameter (always 0) >> (svn_diff__lcs): Removed idx variable (always 0) , let d have either >>

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-29 Thread Stefan Fuhrmann
On 28.05.2011 12:25, Morten Kloster wrote: On Sat, May 28, 2011 at 10:18 AM, Johan Corveleyn wrote: [] Actually, about the theory behind the algorithm: I think it would be quite beneficial if lcs.c would contain more high level documentation about how the algorithm works, and why it works. Righ

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-29 Thread Stefan Fuhrmann
On 27.05.2011 19:29, Morten Kloster wrote: On Fri, May 27, 2011 at 3:13 PM, Julian Foad wrote: On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) wrote: Morten Kloster wrote: [[[ Simpler/faster LCS algorithm in libsvn_di

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-28 Thread Morten Kloster
On Sat, May 28, 2011 at 10:18 AM, Johan Corveleyn wrote: [] > > Actually, about the theory behind the algorithm: I think it would be > quite beneficial if lcs.c would contain more high level documentation > about how the algorithm works, and why it works. Right now it only > contains this referenc

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-28 Thread Johan Corveleyn
On Fri, May 27, 2011 at 7:29 PM, Morten Kloster wrote: > On Fri, May 27, 2011 at 3:13 PM, Julian Foad wrote: >> On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: >>> On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) >>> wrote: >>> > Morten Kloster wrote: >>> > >>> >> [[[ >>>

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Morten Kloster
[] > > I've attached an updated version. > And there I go, forgetting the .txt file type again. HERE is the new version. Morten Index: subversion/libsvn_diff/lcs.c === --- subversion/libsvn_diff/lcs.c(revision 1128318) +++

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Morten Kloster
On Fri, May 27, 2011 at 3:13 PM, Julian Foad wrote: > On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: >> On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) >> wrote: >> > Morten Kloster wrote: >> > >> >> [[[ >> >> Simpler/faster LCS algorithm in libsvn_diff by elimination of

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Johan Corveleyn
On Fri, May 27, 2011 at 3:13 PM, Julian Foad wrote: > On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: [snip] >> Maybe some of the performance improvement (and simplification) can be >> achieved simply by calculating idx0 and idx1 once, and then reusing >> those variables and pass them

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Julian Foad
On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: > On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) > wrote: > > Morten Kloster wrote: > > > >> [[[ > >> Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. > >> > >>* subversion/libsvn_diff/lcs.c > >> (svn_diff_

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Johan Corveleyn
On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) wrote: > Morten Kloster wrote: > >> [[[ >> Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. >> >>* subversion/libsvn_diff/lcs.c >>  (svn_diff__snake_t): Removed idx parameter (always 0) >>  (svn_diff__lcs_t): Removed i

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Fuhrmann Stefan (ETAS/ESA1)
Morten Kloster wrote: > [[[ > Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. > >* subversion/libsvn_diff/lcs.c > (svn_diff__snake_t): Removed idx parameter (always 0) > (svn_diff__lcs_t): Removed idx variable (always 0) , let d have either > sign, and moved the origo of fp