Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Patrick Steinhardt
On Thu, Nov 24, 2016 at 11:48:23AM +, Julian Foad wrote: > Julian Foad wrote: > > Daniel Shahaf wrote: > >> My one comment about your patch is that the import tree should be > >> created under svn-test-work/local_tmp/, rather than under > >> import_tests_data/; I believe the latter should be co

Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Julian Foad
Julian Foad wrote: Daniel Shahaf wrote: My one comment about your patch is that the import tree should be created under svn-test-work/local_tmp/, rather than under import_tests_data/; I believe the latter should be considered read-only. Oh yes! I forgot to call that out. I'll re-work it. OK,

Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Julian Foad
Daniel Shahaf wrote: Julian Foad wrote on Wed, Nov 23, 2016 at 21:03:52 +: Would anyone else care to comment, and review my patch if you think it looks good in principle, please? Thanks for the ping. Both your approach and Patrick's approach would solve the original problem, namely, would

Re: [PATCH] Recreate test data for Git mirrors

2016-11-23 Thread Daniel Shahaf
Julian Foad wrote on Wed, Nov 23, 2016 at 21:03:52 +: > Would anyone else care to comment, and review my patch if you think it looks > good in principle, please? Thanks for the ping. Both your approach and Patrick's approach would solve the original problem, namely, would allow running 'make

Re: [PATCH] Recreate test data for Git mirrors

2016-11-23 Thread Julian Foad
Patrick Steinhardt wrote: On Wed, Nov 16, 2016 at 04:30:55PM +, Julian Foad wrote: On 07/11/16, Patrick Steinhardt wrote: attached is a patch that fixes a test for Git mirrors. The error results from the fact that Git does not track empty directories, which one test relies upon. As we're a

Re: [PATCH] Recreate test data for Git mirrors

2016-11-21 Thread Patrick Steinhardt
On Wed, Nov 16, 2016 at 04:30:55PM +, Julian Foad wrote: > On 07/11/16, Patrick Steinhardt wrote: > > attached is a patch that fixes a test for Git mirrors. The error > > results from the fact that Git does not track empty directories, > > which one test relies upon. > > > > As we're already do

Re: [PATCH] Recreate test data for Git mirrors

2016-11-16 Thread Julian Foad
On 07/11/16, Patrick Steinhardt wrote: attached is a patch that fixes a test for Git mirrors. The error results from the fact that Git does not track empty directories, which one test relies upon. As we're already doing some path processing for the missing directories and as we're also creating