Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-12 Thread Branko Čibej
On 12.02.2013 18:36, Stefan Sperling wrote: > On Wed, Feb 06, 2013 at 08:37:04AM +, Gabriela Gibson wrote: >> On 05/02/13 17:00, Branko Čibej wrote: >>> On 05.02.2013 14:28, Gabriela Gibson wrote: >>> I'm almost sure you meant, "path = gtestlib". >>> >>> -- Brane >>> >> Nope, meant libgtest, en

Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-12 Thread Stefan Sperling
On Wed, Feb 06, 2013 at 08:37:04AM +, Gabriela Gibson wrote: > On 05/02/13 17:00, Branko Čibej wrote: > >On 05.02.2013 14:28, Gabriela Gibson wrote: > >I'm almost sure you meant, "path = gtestlib". > > > >-- Brane > > > Nope, meant libgtest, ended up with both and the mistake compiled %-) > >

Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-06 Thread Gabriela Gibson
On 05/02/13 17:00, Branko Čibej wrote: On 05.02.2013 14:28, Gabriela Gibson wrote: I'm almost sure you meant, "path = gtestlib". -- Brane Nope, meant libgtest, ended up with both and the mistake compiled %-) I think it's working now, see attached patch. Index: configure.ac =

Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-05 Thread Branko Čibej
On 05.02.2013 14:28, Gabriela Gibson wrote: > On 02/02/13 10:31, Branko Čibej wrote: >> You could try adding ${abs_srcdir}/gtest/include to the include path. :) >> Also, you'll get rid of those warnings by adding appropriate paths to >> the private-includes list in build.conf. >> >> -- Brane >> > T

Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-05 Thread Branko Čibej
On 05.02.2013 14:28, Gabriela Gibson wrote: > On 02/02/13 10:31, Branko Čibej wrote: >> You could try adding ${abs_srcdir}/gtest/include to the include path. :) >> Also, you'll get rid of those warnings by adding appropriate paths to >> the private-includes list in build.conf. >> >> -- Brane >> > T

[PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-05 Thread Gabriela Gibson
On 02/02/13 10:31, Branko Čibej wrote: You could try adding ${abs_srcdir}/gtest/include to the include path. :) Also, you'll get rid of those warnings by adding appropriate paths to the private-includes list in build.conf. -- Brane Thanks Brane, I think it is now working, please see attached

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-02 Thread Branko Čibej
On 01.02.2013 19:34, Gabriela Gibson wrote: > On 22/01/13 12:03, Stefan Sperling wrote: >> On Tue, Jan 22, 2013 at 11:15:30AM +, Gabriela Gibson wrote: >>> Part of my 2013 OPW Project for Subversion is to add the Googletest > First of all thanks to Ben for rescuing my messy post =) > > Also tha

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-01 Thread Gabriela Gibson
On 22/01/13 12:03, Stefan Sperling wrote: > > On Tue, Jan 22, 2013 at 11:15:30AM +, Gabriela Gibson wrote: >> >> Part of my 2013 OPW Project for Subversion is to add the Googletest First of all thanks to Ben for rescuing my messy post =) Also thanks to everyone who gave me hints! --- At thi

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-01-30 Thread Daniel Shahaf
Branko Čibej wrote on Wed, Jan 30, 2013 at 11:34:13 +0100: > Whether we want GTest itself to use threads is another question -- I > think the answer is a definite no for now; I can't think of a good > reason to write multithreaded tests at this point. AFAIK, the only uses of threading in subversio

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-01-30 Thread Branko Čibej
On 30.01.2013 10:41, Stefan Sperling wrote: >> # find and set these flags initially, do we need to add a --gtest-CXXFLAGS=? >> # or does the bogstandard CXXUSERFLAGS suffice? > I think just CXXUSERFLAGS is fine. Yes. It is in fact a bad idea to add specific flags just for GTest. >>> # not sure ho

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-01-30 Thread Stefan Sperling
On Tue, Jan 29, 2013 at 10:39:03AM -0800, Ben Reser wrote: > On Tue, Jan 29, 2013 at 9:37 AM, Gabriela Gibson > wrote: > > Please see the attachment for a long long list of questions :) > > Would have been easier for me to look at this if you'd just have > included it inline in the email or at le

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-01-29 Thread Ben Reser
On Tue, Jan 29, 2013 at 9:37 AM, Gabriela Gibson wrote: > Please see the attachment for a long long list of questions :) Would have been easier for me to look at this if you'd just have included it inline in the email or at least as a text/plain attachment (your mailer seems to have decided it wa

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-01-29 Thread Gabriela Gibson
On 22/01/13 11:15, Gabriela Gibson wrote: Part of my 2013 OPW Project for Subversion is to add the Googletest test suite to be compiled by the build system. Please see the attachment for a long long list of questions :) gtestquestions1 Description: application/shellscript

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-01-22 Thread Stefan Sperling
On Tue, Jan 22, 2013 at 11:15:30AM +, Gabriela Gibson wrote: > Part of my 2013 OPW Project for Subversion is to add the Googletest > test suite to be compiled by the build system. > > Googletests's pages can be found here: >http://code.google.com/p/googletest/ > > There are 3 attachments: