Re: [PATCH] Make client diff output streamy

2011-09-16 Thread Hyrum K Wright
I didn't hear any objections, so I committed the patch (along with rev'ing the API) in r1171713. -Hyrum On Tue, Sep 13, 2011 at 1:15 PM, Hyrum K Wright wrote: > In looking over the client diff APIs, I noticed the output parameters > are file handles, not streams.  This feels...odd to me, so I ha

Re: [PATCH] Make client diff output streamy

2011-09-14 Thread Hyrum K Wright
On Wed, Sep 14, 2011 at 4:21 AM, Julian Foad wrote: > On Tue, 2011-09-13, Hyrum K Wright wrote: >> In looking over the client diff APIs, I noticed the output parameters >> are file handles, not streams.  This feels...odd to me, so I hacked >> together the attached patch which updates the APIs to u

Re: [PATCH] Make client diff output streamy

2011-09-14 Thread Julian Foad
On Tue, 2011-09-13, Hyrum K Wright wrote: > In looking over the client diff APIs, I noticed the output parameters > are file handles, not streams. This feels...odd to me, so I hacked > together the attached patch which updates the APIs to use output > streams. It isn't ready to commit just yet, b