Shivani Poddar wrote on Wed, Feb 20, 2013 at 04:00:34 +0530:
> On Wed, Feb 20, 2013 at 2:41 AM, Daniel Shahaf wrote:
>
> > Shivani Poddar wrote on Wed, Feb 20, 2013 at 00:28:41 +0530:
> > > On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote:
> > >
> > > > On Sat, Feb 16, 2013 at 4:26 AM, Shivani P
On Wed, Feb 20, 2013 at 4:31 AM, Ben Reser wrote:
> On Tue, Feb 19, 2013 at 2:33 PM, Shivani Poddar
> wrote:
> > I see. I did run an 'svn update' on my working copy before making any new
> > changed this time around.
> > Maybe i'll recheck the diff yes.
>
> If Subversion can apply the changes (o
On Tue, Feb 19, 2013 at 2:33 PM, Shivani Poddar
wrote:
> I see. I did run an 'svn update' on my working copy before making any new
> changed this time around.
> Maybe i'll recheck the diff yes.
If Subversion can apply the changes (or at least thinks it can)
without creating a conflict it will do
On Wed, Feb 20, 2013 at 3:04 AM, Ben Reser wrote:
> On Tue, Feb 19, 2013 at 10:58 AM, Shivani Poddar
> wrote:
> > Maybe writing "adding tests for svn_checksum_dup() function in
> > svn_checksum.h would be the correct thing to do.
>
> Yes. I'd probably say something like "swig-py: Adding tests f
On Wed, Feb 20, 2013 at 2:41 AM, Daniel Shahaf wrote:
> Shivani Poddar wrote on Wed, Feb 20, 2013 at 00:28:41 +0530:
> > On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote:
> >
> > > On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar
> > > wrote:
> > > > [ [ [
> > > >
> > > > Improving support for s
On Tue, Feb 19, 2013 at 10:58 AM, Shivani Poddar
wrote:
> Maybe writing "adding tests for svn_checksum_dup() function in
> svn_checksum.h would be the correct thing to do.
Yes. I'd probably say something like "swig-py: Adding tests for
svn_checksum_dup()"
> Since in the earlier patches we had L
Shivani Poddar wrote on Wed, Feb 20, 2013 at 00:28:41 +0530:
> On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote:
>
> > On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar
> > wrote:
> > > [ [ [
> > >
> > > Improving support for svn_checksum.h in SWIG bindings.
> >
> > This isn't how I'd word this c
On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote:
> On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar
> wrote:
> > [ [ [
> >
> > Improving support for svn_checksum.h in SWIG bindings.
>
> This isn't how I'd word this commit description. You haven't actually
> improved support at all with this pa
On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar
wrote:
> [ [ [
>
> Improving support for svn_checksum.h in SWIG bindings.
This isn't how I'd word this commit description. You haven't actually
improved support at all with this patch, but rather you've added tests
for a function that already works
9 matches
Mail list logo
