Re: [PATCH] Fix libsvn_ra_serf build with external serf

2021-08-18 Thread Alexandr Miloslavskiy
On 17.08.2021 6:45, Daniel Shahaf wrote: Could you file an issue? I decided to study it a bit more and found more problems, see the newer mail I sent today. For the reasons described there, I decided to abandon the patch: it only fixes half of the problem. While it's already something, I'm out

Re: [PATCH] Fix libsvn_ra_serf build with external serf

2021-08-16 Thread Daniel Shahaf
Alexandr Miloslavskiy wrote on Sat, Aug 14, 2021 at 23:20:26 +0300: > 2) --with-zlib, that has the same problem. But a typical Linux has >system zlib (on my Ubuntu, it's even needed to run `sudo` !) and >in absence of RUNPATH, SVN secretly loads system zlib instead of >the one specified

Re: [PATCH] Fix libsvn_ra_serf build with external serf

2021-08-14 Thread Alexandr Miloslavskiy
On 14.08.2021 15:13, Daniel Shahaf wrote: >> Currently, serf has a very specific form of .pc file, hardcoded in its repo >> [1]. > That's an implementation detail and may change in a future release. > Don't rely on it. >> This only has a single -L. > You shouldn't rely on this either, if possib

Re: [PATCH] Fix libsvn_ra_serf build with external serf

2021-08-14 Thread Daniel Shahaf
Alexandr Miloslavskiy wrote on Sat, Jul 31, 2021 at 13:16:37 +0300: > On 31.07.2021 2:44, Daniel Shahaf wrote: > > > > +SVN_SERF_LIBS=["$SVN_SERF_LIBS `$PKG_CONFIG $serf_pc_arg > > > --libs-only-L | $SED -e 's/^-L/-R/g'`"] > > > > I'm sceptical about the regex. For all I know, there

Re: [PATCH] Fix libsvn_ra_serf build with external serf

2021-07-31 Thread Alexandr Miloslavskiy
On 31.07.2021 2:44, Daniel Shahaf wrote: +SVN_SERF_LIBS=["$SVN_SERF_LIBS `$PKG_CONFIG $serf_pc_arg --libs-only-L | $SED -e 's/^-L/-R/g'`"] I'm sceptical about the regex. For all I know, there may be multiple -L options and there may be leading spaces before the first one. More i

Re: [PATCH] Fix libsvn_ra_serf build with external serf

2021-07-30 Thread Daniel Shahaf
Alexandr Miloslavskiy wrote on Wed, Jul 28, 2021 at 00:38:34 +0300: > +++ build/ac-macros/serf.m4 (working copy) > @@ -170,6 +170,14 @@ >serf_found=yes >SVN_SERF_INCLUDES=[`$PKG_CONFIG $serf_pc_arg --cflags-only-I`] >SVN_SERF_LIBS=[`$PKG_CONFIG $serf_pc_arg --l