Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-29 Thread Philip Martin
Andreas Stieger writes: > Hi, > > On 29/01/15 16:05, Philip Martin wrote: >> Andreas Stieger writes: >> >>> When removing comments which throw SWIG 3.0.4 errors as this: >> >> What errors do you get if you leave the comments in? We don't really >> want to delete the comments from our source c

Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-29 Thread Andreas Stieger
Hi, On 29/01/15 16:05, Philip Martin wrote: > Andreas Stieger writes: > >> When removing comments which throw SWIG 3.0.4 errors as this: > > What errors do you get if you leave the comments in? We don't really > want to delete the comments from our source code. > [ 479s] ./subversion/bindi

Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-29 Thread Philip Martin
Andreas Stieger writes: > When removing comments which throw SWIG 3.0.4 errors as this: What errors do you get if you leave the comments in? We don't really want to delete the comments from our source code. Which version of Python are you using? > I get the following error: > >> import me

Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-29 Thread Andreas Stieger
On 28/01/15 15:09, Philip Martin wrote: > Andreas Stieger writes: > >> I will look into that. The odd thing is when I remove the comments, >> check-swig-py trips over a svn_pool_create() call without arguments in >> proxy_apr.swg which looks wrong. > > That's python code, not C. The function is

Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-28 Thread Philip Martin
Andreas Stieger writes: > I will look into that. The odd thing is when I remove the comments, > check-swig-py trips over a svn_pool_create() call without arguments in > proxy_apr.swg which looks wrong. That's python code, not C. The function is defined earlier in the file and forwards to _core.

Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-28 Thread Andreas Stieger
Hi, On 28/01/15 12:39, Bert Huijben wrote: > I applied a patch similar to the first hunk in r1655262, as this file is > processed mostly as C code. > > I'm not sure about the other hunks. It looks like they could be processed as > python where the other syntax is preferred. I will look into t

RE: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-28 Thread Bert Huijben
> -Original Message- > From: Andreas Stieger [mailto:andreas.stie...@gmx.de] > Sent: zondag 25 januari 2015 22:53 > To: dev@subversion.apache.org > Subject: [PATCH] Fix build errors in bindings with SWIG 3.0.4 > > Hello, > > I saw build errors in the bindings with SWIG 3.0.4: > ./subver

Re: [PATCH] Fix build errors in bindings with SWIG 3.0.4

2015-01-26 Thread Philip Martin
Andreas Stieger writes: > Index: subversion/bindings/swig/include/proxy.swg > === > --- subversion/bindings/swig/include/proxy.swg(revision 1654697) > +++ subversion/bindings/swig/include/proxy.swg(working copy) > @@