Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-26 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, 25 May 2020 11:18 -0400: > Bringing this portion from [1] back to this thread: > > On Sun, May 24, 2020 at 8:38 PM Daniel Shahaf wrote: > > Nathan Hartman wrote on Sun, 24 May 2020 18:28 -0400: > > > Asking because I ran the latter on latest trunk with this change >

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-25 Thread Nathan Hartman
iciently than the previous one. Nathan [1] "Sporadic davautocheck failure in trunk? (was: Re: [PATCH] Fix an inefficient way to fill an array of inherited properties)" 24 May 2020 https://lists.apache.org/thread.html/r7e332a8d760527d754d4a5d23094d7712605a4eb10e76a8e91f1f2c5%40%3Cdev.subversion.apache.org%3E

Sporadic davautocheck failure in trunk? (was: Re: [PATCH] Fix an inefficient way to fill an array of inherited properties)

2020-05-24 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 24 May 2020 18:28 -0400: > On Sun, May 24, 2020 at 6:00 PM Daniel Shahaf wrote: > > > > Nathan Hartman wrote on Sun, 24 May 2020 12:10 -0400: > > > On Sat, May 23, 2020 at 8:38 PM Branko Čibej wrote: > > > > For my part, I just didn't get around to it. I think it

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-24 Thread Nathan Hartman
On Sun, May 24, 2020 at 6:00 PM Daniel Shahaf wrote: > > Nathan Hartman wrote on Sun, 24 May 2020 12:10 -0400: > > On Sat, May 23, 2020 at 8:38 PM Branko Čibej wrote: > > > For my part, I just didn't get around to it. I think it should be > > > committed. > > > > I committed it in r1878084. > >

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-24 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 24 May 2020 12:10 -0400: > On Sat, May 23, 2020 at 8:38 PM Branko Čibej wrote: > > For my part, I just didn't get around to it. I think it should be > > committed. > > I committed it in r1878084. Thanks, Nathan. I'd have done this myself, but my build environment

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-24 Thread Nathan Hartman
On Sat, May 23, 2020 at 8:38 PM Branko Čibej wrote: > For my part, I just didn't get around to it. I think it should be committed. I committed it in r1878084. Nathan

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-23 Thread Branko Čibej
On 24.05.2020 00:17, Daniel Shahaf wrote: > Branko Čibej wrote on Fri, 15 May 2020 17:07 +0200: >> On 15.05.2020 16:54, Denis Kovalchuk wrote: >>> Hello. >>> >>> I think that currently the code that obtains inherited properties for >>> servers >>> that don't support the capability uses an ineffici

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-23 Thread Daniel Shahaf
Branko Čibej wrote on Fri, 15 May 2020 17:07 +0200: > On 15.05.2020 16:54, Denis Kovalchuk wrote: > > Hello. > > > > I think that currently the code that obtains inherited properties for > > servers > > that don't support the capability uses an inefficient way of array filling. > > At each iterati

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

2020-05-15 Thread Branko Čibej
On 15.05.2020 16:54, Denis Kovalchuk wrote: > Hello. > > I think that currently the code that obtains inherited properties for servers > that don't support the capability uses an inefficient way of array filling. > At each iteration, all previously added properties are moved one position to > the r