On Wed, Dec 01, 2010 at 10:48:37AM +0530, Ramkumar Ramachandra wrote:
> Hi Stefan,
>
> Thanks for the suggestions. How about this?
+1
A single 'Approved by: stsp' line in the log message is sufficient,
you don't necessarily need the 'suggested' and 'review' lines.
Thanks!
>
> [[[
> Makefile.s
Hi Stefan,
Thanks for the suggestions. How about this?
[[[
Makefile.svn: Optionally allow building with threading support
* tools/dev/unix-build/Makefile.svn: Add a new THREADING variable to
control whether APR and sqlite should be built with threading
support.
Suggested by: stsp
Review by:
On Tue, Nov 30, 2010 at 07:52:36PM +0100, Stefan Sperling wrote:
> ifdef THREADING
> THREADING_FLAG=--enable-threads
> else
> THREADING_FLAG=--enable-threads
> endif
Oops... s/enable/disable/ on the second line obviously :)
On Wed, Dec 01, 2010 at 12:18:08AM +0530, Ramkumar Ramachandra wrote:
> > Your patch is too short. It's missing at least one hunk. Because if
> > threading
> > is enabled for APR, you should also enable it for sqlite and any other
> > dependencies affected.
>
> Ok, got it. Here's my second try.
>
Hi,
Stefan Sperling writes:
> The first is that I use OpenBSD and OpenBSD's threading implementation
> is a pure userspace implementation. It has to set stdin and stdout to
> non-blocking -- otherwise, whenever a thread blocks for i/o in the kernel the
> userspace thread-scheduler would also be bl
On Tue, Nov 30, 2010 at 02:09:10PM +0530, Ramkumar Ramachandra wrote:
> Hi,
>
> Here's a quick patch to fix Makefile.svn. I need a +1 to commmit this.
If the build breaks because of threadless APR, that's a bug in Subversion,
not in Makefile.svn.
If you want to build with thread support, please
6 matches
Mail list logo
