RE: svn commit: r1740170 -/subversion/trunk/subversion/libsvn_client/conflicts.c

2016-04-21 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: donderdag 21 april 2016 09:43 > To: dev@subversion.apache.org > Cc: comm...@subversion.apache.org > Subject: Re: svn commit: r1740170 - > /subversion/trunk/subversion/libsvn_client/conflicts.

Re: svn commit: r1740170 -/subversion/trunk/subversion/libsvn_client/conflicts.c

2016-04-21 Thread Stefan Sperling
On Thu, Apr 21, 2016 at 09:40:07AM +0200, Branko Čibej wrote: > It is wrong to use conflict->local_abspath to construct the relative > URL. Yes, it is. But where is the alleged code that does this? I don't see it. And I don't think I've written it.

Re: svn commit: r1740170 -/subversion/trunk/subversion/libsvn_client/conflicts.c

2016-04-21 Thread Stefan Sperling
On Wed, Apr 20, 2016 at 10:19:56PM +0200, Bert Huijben wrote: > The path calculation here 100% assumes that the working copy is always a > clean check out from ^/. This might be the case in our test suite, but in > almost every normal user scenario this isn’t the case. > > You can’t just calcula